feat: Distance is measured in mi for en. #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
amaury1093
reviewed
Jul 31, 2019
There was a problem hiding this comment.
True, I've never thought of that. Thanks a lot!
Just a small comment, I'll merge right after.
this may encourage the breakout of the en-* translation
Totally true. We have translations files for Spanish and French, but they need some TLC so make sure the design doesn't break (words too long etc...), so I'm reluctant to enable them right now.
However, the en-US/en-GB distinction makes sense, as the design won't break.
|
Follow-up PR: #154. cc @Brad-Christie is this something you'd like to work on? If not, I'll pick it up |
Brad-Christie
added a commit
to Brad-Christie/shoot-i-smoke
that referenced
this pull request
Jul 31, 2019
feat: Distance is measured in mi for en (shootismoke#153)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted translation to display miles for en.
Given en-GB uses km while en-US (actually, US exclusively) uses mi, this may encourage the breakout of the en-* translation (despite this purposeful trim).
Also I can appreciate how clean the code is, so (arguably) my approach is a bit of a sledgehammer., however haversine does naively accept a
unitoption so it would be nice to see that leveraged.