Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable translations for en-* languages #154

Closed
amaury1093 opened this issue Jul 31, 2019 · 0 comments · Fixed by #166
Closed

Enable translations for en-* languages #154

amaury1093 opened this issue Jul 31, 2019 · 0 comments · Fixed by #166
Milestone

Comments

@amaury1093
Copy link
Member

We have translations for Spanish #79 and French Portuguese #89. They should not be enabled before we actually make sure they don't break the design (e.g. words too long).

However, for en-* languages, we could already support them, as there's little risk of breaking the design. So the idea would be to have en-GB.json, en-US.json and even other en-*.json language files, and replace

https://github.com/amaurymartiny/shoot-i-smoke/blob/e1305b684a086c6b7c1a9c1c70a7bca65bc12dd6/App/localization/index.ts#L32-L34

with loading the actual correct language file corresponding to the user's phone's locale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant