-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable translations for en-* languages #154
Milestone
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have translations for Spanish #79 and French Portuguese #89. They should not be enabled before we actually make sure they don't break the design (e.g. words too long).
However, for en-* languages, we could already support them, as there's little risk of breaking the design. So the idea would be to have
en-GB.json
,en-US.json
and even otheren-*.json
language files, and replacehttps://github.com/amaurymartiny/shoot-i-smoke/blob/e1305b684a086c6b7c1a9c1c70a7bca65bc12dd6/App/localization/index.ts#L32-L34
with loading the actual correct language file corresponding to the user's phone's locale.
The text was updated successfully, but these errors were encountered: