feature(history): store data each hour #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: lucienbl <[email protected]>
Possible dark video background issue fix
* Add eslint * Run eslint on files * Update contributing guide * Update README * Typo
* Spanish translation * correction * improvement spanish translation
* Add spanish * Add missing translations
* Spanish translation * correction * improvement spanish translation * missing spanish translations added
* Update README.md * Update README.md
* cherry-pick * Add button on picker * Add button to change language
Bumps [jest](https://github.com/facebook/jest) from 24.5.0 to 24.8.0. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) - [Commits](jestjs/jest@v24.5.0...v24.8.0)
Bumps sentry-expo from 1.11.2 to 1.12.0.
…otismoke#95) Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.17.2 to 2.17.3. - [Release notes](https://github.com/benmosher/eslint-plugin-import/releases) - [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.17.2...v2.17.3)
Bumps [truncate](https://github.com/FGRibreau/node-truncate) from 2.0.1 to 2.1.0. - [Release notes](https://github.com/FGRibreau/node-truncate/releases) - [Changelog](https://github.com/FGRibreau/node-truncate/blob/master/CHANGELOG.md) - [Commits](FGRibreau/node-truncate@v2.0.1...v2.1.0)
Lb expo upgrade
Merge master into history-feature
|
|
amaury1093
requested changes
Jun 29, 2019
There was a problem hiding this comment.
Thanks a lot for this PR 💯 ! I'll test more thoroughly on-device, but at the first glance it looks good.
There are some stuff to change though, like removing the TS stuff (though I logged #96 some time ago, I would like to change it to TS too).
amaury1093
reviewed
Jun 30, 2019
Revert "Am feature history"
amaury1093
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should store necessary data each hour in a local SQLite DB.