feat: Replace share text with an image on iOS #242
Conversation
jamespearson
changed the title
jamespearson
force-pushed
the
share-image
branch
from
db00016
to
c77f94f
Compare
jamespearson
force-pushed
the
share-image
branch
from
c77f94f
to
f2157b2
Compare
There was a problem hiding this comment.
This is a very good quality PR, thanks a lot @jamespearson!
I'm not sure about the UX with the black modal, but I'll let @marceloscoelho decide on that. Anyways, the functionality is here and working well, so after these small comments I'm ready to merge this PR.
I have one question though @jamespearson: Is it possible to share in iOS a picture and a text? Or add a caption to the picture?
|
|
||
| export const FrequencyContext = createContext(); | ||
|
|
||
| export function FrequencyContextProvider ({ |
There was a problem hiding this comment.
Yes, this is a good idea, thanks!
| }, | ||
|
|
||
| buttonContainer: { | ||
| paddingVertical: 20 |
|
@amaurymartiny Fixed those notes, thanks. I'm going to look at adding the wording with the image and the android issue, but thought once this was approved I'd raise both of those as new issues for anyone else who wanted to jump in too. What do you think? |
jamespearson
force-pushed
the
share-image
branch
from
fb65781
to
7c01b69
Compare
That's a good idea. Thanks for the PR @jamespearson! |
fixes #35
As raised in #35 the share content could be nicer... so I changed it (on iOS only) to this...
This opens the image in a modal and used "react-native-view-shot" to capture the image and share.
At the moment there are 2 bugs in "share" that stop this from being perfect:
Here is the process in action: