Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Button with screenshot and link #35

Closed
amaury1093 opened this issue May 25, 2018 · 8 comments · Fixed by #242
Closed

Share Button with screenshot and link #35

amaury1093 opened this issue May 25, 2018 · 8 comments · Fixed by #242
Assignees
Labels
good first issue Good for newcomers

Comments

@amaury1093
Copy link
Member

One of the strong points of this app is the design (thanks Marcelo!), esp. the homepage with the cigarettes.

I'm thinking, it would be perfect, in the "Share with friends" button, to share a screenshot + a link to download, instead of some plain text.

@amaury1093 amaury1093 changed the title Share Button Share Button with screenshot and link Aug 29, 2018
@amaury1093 amaury1093 added the good first issue Good for newcomers label Apr 17, 2019
@viveksb007
Copy link

Hi I would like to take this up.

@amaury1093
Copy link
Member Author

Hey @viveksb007, I would really appreciate this!

Is the issue description clear? Do you need some more indications?

@viveksb007
Copy link

Yes its clear. But to be sure when sharing the result. App should provide the below image + app download link right?

photo_2019-10-02 18 35 11

@amaury1093
Copy link
Member Author

amaury1093 commented Oct 2, 2019

No, not this image. It should be a screenshot of the home page, with the cigarette count, for example this image https://twitter.com/shootismoke/status/1077481829970649088.

Of course, it should take a screenshot of the actual screen on the home page, and share that image.

@viveksb007
Copy link

viveksb007 commented Oct 2, 2019

Yeah got it. Will give it a try. Can you assign it to me?

@viveksb007
Copy link

viveksb007 commented Oct 2, 2019

Hi @amaurymartiny is there any channel where I can ask queries?
I am facing issues in running app on my Android device. Followed all the steps in README.
Just obtained API key for http:https://aqicn.org/api/ and wrote "undefined" for others. After building I am getting following error.

It's my first time using this stack for App development.

photo_2019-10-02 22 12 03

@amaury1093
Copy link
Member Author

Hey Vivek! Sorry about that, it's my fault. Instead of "undefined", it should just be null (without quotes) in app.json

I updated the README in consequence.

And you are right, there should be a channel to ask this sort of questions. I just created https://spectrum.chat/shootismoke!

@jamespearson
Copy link
Contributor

Sorry, I started it as part of Hacktoberfest, and none of these comments were here when I last looked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants