-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace share text with an image on iOS #242
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7dbbef6
Moved Cigarette in to a common component
27b107d
Made frequency terms global (not screen specific)
f6451d6
Moved the cigarette count calculation to the cigarette block
acf6590
Moved frequency from Home state to global context
ca4762b
Linting
e9dadff
Added a share screen and share image
9edc6bb
Added a ShareScreen modal overlay
828cc35
i18n for the close button
c87921c
Fixed a circular import
a9d54f5
Replaced previous share with the image
3fae7d4
Keep the existing text notification on Android
58c8cc3
Linting
f2157b2
Resolved Merge Conflict
77ed787
👌🏻 Renamed currentFrequency as frequency
2bf5212
👌🏻 Added a blank line between relative and absolute imports
71a526a
👌🏻 Removed the hard coded values (replaced with theme values)
7c01b69
👌🏻 Linting
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Moved frequency from Home state to global context
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
// Sh**t! I Smoke | ||
// Copyright (C) 2018-2019 Marcelo S. Coelho, Amaury Martiny | ||
|
||
// Sh**t! I Smoke is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
|
||
// Sh**t! I Smoke is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
|
||
// You should have received a copy of the GNU General Public License | ||
// along with Sh**t! I Smoke. If not, see <http:https://www.gnu.org/licenses/>. | ||
|
||
import React, { createContext, useState } from 'react'; | ||
import { Frequency } from '../Screens/Home/SelectFrequency'; | ||
|
||
export const FrequencyContext = createContext(); | ||
|
||
export function FrequencyContextProvider ({ | ||
children | ||
}: { | ||
children: JSX.Element; | ||
}) { | ||
const [currentFrequency, setFrequency] = useState<Frequency>('daily'); | ||
jamespearson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
return ( | ||
<FrequencyContext.Provider | ||
value={{ | ||
currentFrequency, | ||
setFrequency | ||
}} | ||
> | ||
{children} | ||
</FrequencyContext.Provider> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,4 +16,5 @@ | |
|
||
export * from './api'; | ||
export * from './error'; | ||
export * from './frequency'; | ||
export * from './location'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a good idea, thanks!