Refactor js code to integrate Flux Alt #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@justin808 Lint errors have been addressed. Also updated the npm shrinkwrap. Let me know if you want to merge. Thanks. |
8496ecc
to
bdde1c1
Compare
bdde1c1
to
fe8fd47
Compare
|
LGTM |
justin808
added a commit
that referenced
this pull request
Apr 9, 2015
Refactor js code to integrate Flux Alt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@justin808 Please review. This PR contains the Flux Alt refactoring on top of the latest master. One commit.
I'll close and delete the previous feature/flux_integration branch.
Note that the alt library does not get installed by
npm installalthough it is defined in package.json. I suspect there is a dependency conflict somewhere, although I would expect npm to error out. I didn't get a chance to investigate so for now I'm installing it manuallycd client && npm install alt.