Flux integration #27
Closed
Flux integration #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentBox component to use Flux
| const rawMarkup = marked(this.props.text); | ||
| return ( | ||
| <div className="comment"> | ||
| <h2 className="commentAuthor foobar"> |
mbreining
force-pushed
the
feature/flux_integration
branch
2 times, most recently
from
769c6d3
to
d2952c2
Compare
|
I have the following error when I tried to go on localhost:4000 Everything works fine on localhost:3000. Thx for your alt integration. Awesome work ! |
|
@fredericgrati This PR is no longer valid. I will close it shortly. Check out PR #28 instead. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@justin808 Please review. I added support for Flux (https://github.com/goatslacker/alt). The functionality remains the same.
Note that the latest master has been merged into this branch.
Also note that the alt library does not get installed by
npm installalthough it is defined in package.json. I suspect there is a dependency conflict somewhere, although I would expect npm to error out. I didn't get a chance to investigate so for now I'm installing it manuallycd client && npm install alt.