Backport several style changes from Gecko (4) #29848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jun 7, 2023
Backport several style changes from Gecko (4) <!-- Please describe your changes on the following line: --> This continues #29816. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Test results for linux-wpt-layout-2013 from try job (#5194557113): Flaky unexpected result (9)
Stable unexpected results that are known to be intermittent (19)
Stable unexpected results (9)
|
|
💔 Test failed - checks-github |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jun 7, 2023
Backport several style changes from Gecko (4) <!-- Please describe your changes on the following line: --> This continues #29816. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Test results for linux-wpt-layout-2013 from try job (#5199821464): Flaky unexpected result (13)
Stable unexpected results that are known to be intermittent (21)
Stable unexpected results (6)
|
|
💔 Test failed - checks-github |
…d name to dash Differential Revision: https://phabricator.services.mozilla.com/D128668
For now, use IntoIterator to figure the right type to add the bound. If we need this on types that are iterable but don't provide IntoIterator, we can add another attribute field or something. Differential Revision: https://phabricator.services.mozilla.com/D129962
This I noticed while working on the following patches. Shouldn't have any behavior change: the behavior does in fact match the element state flag semantics correctly if we do this. We did split the dir flags into two element bits a while ago. :not(:dir()) still behaves correctly of course, and we have tests for that. Differential Revision: https://phabricator.services.mozilla.com/D130734
…ctly Use the same document state mechanism we have for :moz-locale-dir. Also, simplify the setup of the later to be the same as :dir(), allowing the matching code to be less repetitive. This should fix some flakiness in chrome mochitests, but we have no existing tests for these pseudo-classes more generally and since they're just chrome-only I'm not super-excited about adding more. Differential Revision: https://phabricator.services.mozilla.com/D130735
…ss chrome-only selectors. r=boris Without this some tests fail with the previous patch because code like: https://searchfox.org/mozilla-central/rev/267682a8f45221bf0bfe999d4a0239706a43bc56/browser/base/content/browser-gestureSupport.js#651 starts throwing. Unfortunately I had missed that on my try run, because the error message didn't include that exception (it seemed like an intermittent browser-chrome failure instead). We could expose a ChromeOnly API for this, but this seems better. This fixes it trivially, and also removes the "no url data" situation from the selector parser, which is nice. Differential Revision: https://phabricator.services.mozilla.com/D130818
Behind a pref for now. Given these selectors do nothing on non-chrome documents (they just don't match) it seems worth trying. A cursory search seems to indicate they're not used for UA detection or something like that (or at least I haven't found such an usage). Differential Revision: https://phabricator.services.mozilla.com/D130736
…ipped successfully And remove code for :-moz-submit-invalid completely. Differential Revision: https://phabricator.services.mozilla.com/D130737
In some platforms (like macOS, windows dark mode, android, and some gtk themes) the foreground selection color might be `currentcolor`, and that doesn't generally guarantee enough contrast with the attention background. Remove HeadlessLookAndFeelGTK's handling of this color since it's useless (always overridden by prefs in all.js) Differential Revision: https://phabricator.services.mozilla.com/D130617
…-name>)' Differential Revision: https://phabricator.services.mozilla.com/D129955
…rty that is no longer needed Differential Revision: https://phabricator.services.mozilla.com/D129957
…ors (except windows HCM) This causes (among other things) pages to be dark when using regular windows system colors and forcing colors to "always", which is nice. Differential Revision: https://phabricator.services.mozilla.com/D131165
Apparently using transparent borders and outlines is a common accessibility technique to make those visible in HCM. Bug 1740924 comment 9 seemed to indicate we were the only browser rendering those browsers, but I just confirmed that Edge at least does show them. Keep respecting system colors as that's per spec. Differential Revision: https://phabricator.services.mozilla.com/D131412
This effectively backs out bug 1623396. See: w3c/csswg-drafts#6006 https://drafts.csswg.org/css-variables/#guaranteed-invalid-value And related discussion. Matches Chrome stable as per https://groups.google.com/a/chromium.org/g/blink-dev/c/0xrbzYe_vxU/m/7bsL76n9CgAJ Depends on D116459 Differential Revision: https://phabricator.services.mozilla.com/D116460
This patch is generated by running `cargo +nightly fmt` under `servo/components/style/` and `servo/ports/geckolib` against mozilla-central https://hg.mozilla.org/mozilla-central/rev/b193f2e7a6a5d1f042c957ea4acd5c89bf210512 My nightly version is: 1.58.0-nightly (c9c4b5d72 2021-11-17) Manually remove the redundant braces in author_styles.rs to fix a warning. Differential Revision: https://phabricator.services.mozilla.com/D131556
This patch adds `scrollbar-gutter` property in CSS Overflow level 3 [1] to the style system. `devtools/shared/css/generated/properties-db.js` is generated by `./mach devtools-css-db`. [1] https://drafts.csswg.org/css-overflow-3/#scrollbar-gutter-property Differential Revision: https://phabricator.services.mozilla.com/D131460
…: block As per https://fullscreen.spec.whatwg.org/#new-stacking-layer: If its specified display property is contents, it computes to block. Differential Revision: https://phabricator.services.mozilla.com/D131585
…ck font family This seems like more sensible behavior. We have another use of only_generic(), but that affects font sizing and other browsers agree with us there: <div style="font-family: monospace">Should be 13px</div> <div style="font-family: something, monospace">Should be 16px</div> So not touching that one. Differential Revision: https://phabricator.services.mozilla.com/D130732
… the CSS Contain specification Add initial parsing support for the CSS `content-visibility` attribute. Currently these parsed values have no effect. Differential Revision: https://phabricator.services.mozilla.com/D140834
See comment as for why, and linked bugs, in particular: https://bugzilla.mozilla.org/show_bug.cgi?id=1755713#c16 And the following screenshot for example. Differential Revision: https://phabricator.services.mozilla.com/D141514
The flags stylo cares about reading and writing potentially at the same time are disjoint, so there's no need for any strong memory ordering. Differential Revision: https://phabricator.services.mozilla.com/D141829
MANUAL PUSH: Bustage fix CLOSED TREE
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jun 9, 2023
Backport several style changes from Gecko (4) <!-- Please describe your changes on the following line: --> This continues #29816. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Test results for linux-wpt-layout-2013 from try job (#5220343325): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (18)
|
|
☀️ Test successful - checks-github |
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jun 9, 2023
Backport several style changes from Gecko (4) <!-- Please describe your changes on the following line: --> This continues #29816. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Test results for linux-wpt-layout-2020 from try job (#5221161981): Flaky unexpected result (2)
Stable unexpected results that are known to be intermittent (1)
|
|
☀️ Test successful - checks-github |
|
@bors-servo r+ |
|
📌 Commit aefaa3f has been approved by |
|
Test results for linux-wpt-layout-2020 from try job (#5242287673): Flaky unexpected result (2)
|
|
Test results for linux-wpt-layout-2013 from try job (#5242287673): Flaky unexpected result (22)
Stable unexpected results that are known to be intermittent (7)
|
|
☀️ Test successful - checks-github |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #29816.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors