Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle "close window" event and interrupt signal #3

Closed
kud1ing opened this issue May 6, 2012 · 7 comments
Closed

Handle "close window" event and interrupt signal #3

kud1ing opened this issue May 6, 2012 · 7 comments
Labels
I-enhancement No impact; the issue is a missing or proposed feature.

Comments

@kud1ing
Copy link

kud1ing commented May 6, 2012

Currently servo can only be ended using kill -9.

It should end when

  • pressing the "window close" button
  • entering Ctrl+C (interrupt signal)

Edit: This is on Mac OS X
@nikomatsakis
Copy link
Contributor

I definitely have these problems... but does it work on Linux?

@brson
Copy link
Contributor

brson commented May 7, 2012

neither window close nor ctrl+c work on linux either, though the key press is intercepted correctly

@eholk
Copy link
Contributor

eholk commented Jul 9, 2012

On mac, I'm not seeing any evidence that any keypresses are received correctly...

eholk added a commit to eholk/servo that referenced this issue Jul 26, 2012
@eholk
Use pipe streams for keyboard events.
b10b052 
Termination detection in pipes also allows Servo to close on its own accord (issue servo#3)
@catamorphism
Copy link
Contributor

Ctrl-C works on Mac in the window where you started Servo, but not in the browser window. I'm going to investigate how to make the close button work.

@ghost ghost assigned catamorphism Aug 20, 2012
@catamorphism
Copy link
Contributor

Evidently the answer is that GLUT doesn't support the "close window" widget on the Mac. D'oh. (Command-Q works for quitting, though.)

@evilpie evilpie mentioned this issue Aug 2, 2013
Closed
@tikue tikue mentioned this issue Aug 2, 2013
Closed
recrack added a commit to recrack/servo that referenced this issue Aug 7, 2013
@recrack
Update Makefile.in servo#3
88a31f7
@jdm
Copy link
Member

jdm commented Apr 18, 2014

This was fixed by shifting to GLFW afaik.

@jdm jdm closed this as completed Apr 18, 2014
@kud1ing
Copy link
Author

kud1ing commented Apr 19, 2014

Confirmed, thanks.

ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
@odinho
Merge pull request servo#3 from Yaffle/patch-2
28c81f6 
Update format-field-parsing.htm
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
@fsasaki
Merge pull request servo#3 from finnle/patch-3
97a0652 
Update storagesize9xml.xml
@mskrzypkows mskrzypkows mentioned this issue Jan 27, 2015
Closed
Munksgaard added a commit to Munksgaard/servo that referenced this issue May 4, 2015
@Munksgaard
Add close-vec.rs example
74587cd 
This shows how we can partially get around the problem with types
defined in foreign crates etc.

In rust-sesssions, we could imagine creating a trait and impl like this:

```
unsafe trait Closeable {
    fn close(self);
}

unsafe impl Closeable for Vec<Chan<Eps>> {
  #[allow_drop="collections::vec::Vec<Chan<Eps>>"]
  fn close(self) { }
}
```

Of course, there's a problem with the environment, as the Chan actually
looks like `Chan<E, Eps>`, where E is something we don't know, and don't
really care about.

TODO: Some kind of pattern matching could perhaps solve this?

cc servo#3
gurobokum added a commit to gurobokum/servo that referenced this issue May 5, 2015
@gurobokum
Start using on_refresh_driver_tick servo#5681
132b098 
Critics servo#3
@staktrace staktrace mentioned this issue Jun 26, 2015
Closed
@oesiman oesiman mentioned this issue Sep 27, 2015
Closed
@pcwalton pcwalton mentioned this issue Dec 15, 2015
Merged
bors-servo pushed a commit that referenced this issue Dec 17, 2015
Auto merge of #8990 - pcwalton:advance-for-range-optzns, r=mbrubeck
67c3cb3 
Optimize `TextRun::advance_for_range`.

The combined effects of these optimizations move `advance_for_range` from #1 in the layout profile on all sites I tested to #2, #3, or #4, depending on the site.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8990)
<!-- Reviewable:end -->
@larsbergstrom larsbergstrom mentioned this issue Jan 11, 2016
Merged
This was referenced Jun 7, 2023
Merged
Merged
Merged
This was referenced Jun 14, 2023
Merged
Merged
This was referenced Jun 25, 2023
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 3, 2023
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this issue Aug 31, 2023
Merged
4 tasks
@github-actions github-actions bot mentioned this issue Sep 7, 2023
Merged
3 tasks
@github-actions github-actions bot mentioned this issue Oct 18, 2023
Merged
4 tasks
This was referenced Nov 17, 2023
Merged
Merged
@github-actions github-actions bot mentioned this issue Nov 28, 2023
Merged
4 tasks
This was referenced Jan 25, 2024
Merged
Merged
This was referenced Feb 8, 2024
Merged
Merged
Merged
This was referenced Feb 23, 2024
Merged
Merged
Merged
@github-actions github-actions bot mentioned this issue Mar 13, 2024
Merged
3 tasks
pewsheen pushed a commit to pewsheen/servo that referenced this issue Jun 18, 2024
@wusyong
Merge pull request servo#3 from pewsheen/readablestream
0996729 
feat: add helper function to extract hwm and size from queuing strategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-enhancement No impact; the issue is a missing or proposed feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jdm @eholk @brson @nikomatsakis @kud1ing @catamorphism