DocSearch #1754
Merged
DocSearch #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1754 +/- ##
=======================================
Coverage 71.18% 71.18%
=======================================
Files 92 92
Lines 11190 11190
=======================================
Hits 7966 7966
Misses 3224 3224 |
|
I added the readthedocssphinx search when experimenting with which one to use. DocSearch just seemed a lot nicer. It's got fuzzy matching, so using UK vs US spelling doesn't matter, also gives more context about results. |
ivirshup
reviewed
Mar 22, 2021
ivirshup
reviewed
Mar 22, 2021
ivirshup
approved these changes
Mar 29, 2021
|
Looking good! But somehow there’s like 3 times the same for each result … I assume two are expected as one is the page title and one the doc item title (e.g. function name), and we have one page per function/class. But shouldn’t one side of the vertical line be e.g. the first line of the docstring?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rendered
/edit: huh! weird, seems that readthedocs-sphinx-search pops up instead. why do we try to use docsearch instead of that one?