updated test that works with pandas 1.2 #1562 #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that having the case with identical values is actually useful, since otherwise we're not checking this edge case. Ideally, I think we should be using a stable sort so results will be consistent in the case of similar values. |
|
Huh, it looks like pandas does not have the option for doing a stable sort here, so maybe we should change the test. |
|
Yeah, I check to see if there was some option to get the same sorting regardless of the pandas version, but could not find anything. I will merge the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1562
A test requiring sorting was updated such that it works the same with pandas<1.2.0 or pandas>=1.2.0.
The issue was caused by the test having identical values to sort.