Various fixes for the startOfWeek prop #22
Conversation
When using a Gregorian calendar you can change the startOfWeek value but the titles do not move with it. Rotate the titles array when a non-zero value for startOfWeek is passed. If you customise the titles (via components.titleOfWeek.titles) AND the startOfWeek then you should pass the titles array always starting from Sunday. It will be reordered automatically allowing you to easily change startOfWeek prop without any other logic needed. Also add some story knobs to test.
This should always start with Sunday.
|
Just FYI, a screen shot showing the problem of the shift value often being greater than 7 and thus leaving a blank row (taken from the "App props" story)
I've confirmed it now seems to work properly in both modes (although it took me a while to realise my ignorance when reading the Jalali calendar that as well as reading each individual month from from R-L I also had to read the previous and next months from R-L too!! Obvious really but took me a while 🤦🏼 ) FWIW, I've continued the approach of not allowing startOfWeek in Jalali mode as I presume it's just never presented different in practice. If it should be possible to change it, feel free to let me know and I can make it so. 😃 |
I had fixed this in 072d886 but for some reason only the header row fix made it into the commit. It seems the header row has become corrupted again (likely due to Visual Studio Code trying to be too clever.
When we've not yet selected a hoverDay and there is no 'to' date selected, the date we used for comparisons was just an empty string. If this is the case we should use our 'from' date. Fixes samsam-ahmadi#21
There was a problem hiding this comment.
I Just fixed the number of start of week for Jalali and Then everything is perfect
@coling Thanks
Great. I wasn't sure about that side of things so thanks for fixing it up. I knew the 7 that was there previous would be the same as 0, but wasn't sure if it was the correct result in the end. Thanks for reviewing and merging 😃 |
Description
In both Jalali & Gregorian modes the calculation to work out the shift (padding) used at the start of the month to properly line up the start day with it's appropriate day of the week was wrong. It could lead to a whole blank row. There were also no bounds checks on the value passed in.
I've fixed these issues and documented the prop.
I've also fixed the day titles by default when non-zero values of startOfWeek are passed so these are reordered correctly as you'd expect.
Types of changes
(not really a new feature as it was there just not documented fully as it didn't work :-p)