-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] mouse hover effect on range picker #21
Comments
I've seen this too. I'll try and take a look sometime soon if @samsam-ahmadi doesn't beat me to it |
When we've not yet selected a hoverDay and there is no 'to' date selected, the date we used for comparisons was just an empty string. If this is the case we should use our 'from' date. Fixes samsam-ahmadi#21
Just FYI, I fixed this in a commit I've just included in an open pull request #22 |
@coling @metalmaninfr, Thank you so much, Sorry I have feeling bad. I will check them ASAP. |
There is no rush on my part. Rest up and feel better :-) |
I have same problem with the RangePicker component when I try to setState dates(from, to), mouse hover effect disappears. |
I think this is fixed now @samsam-ahmadi as I did fix up the class application in the recent pull request you just merged. You may want to tidy it up and make it clearer/better tho' 😄 |
Thanks @coling. |
I fixed it with this commit And new release is available: @1.7.0 |
🤦🏼 I mustn't have tested that properly.... Sorry 😢 and thanks for the fix 😄 |
I'm still having the same problems, as I am resetting the |
@metalmaninfr Would you please reproduce it in the codesandbox ? |
@metalmaninfr Please check this version [email protected] |
seems to work, thank you :) |
@metalmaninfr Great. I closed this issue, if you have any other issue or ideas feel free to open issue or PR. |
thank you for fixing this bug)) |
Expected Behavior
on range date picker, on 1st onClick on date, the mouse hover effect should stay on the day we clicked before mouseLeave
Current Behavior
When I click on a day, a selection of days has a mouse hover effect
Possible Solution
no idea
Your Environment
Mac os 11.4 - Chrome
React 17.1
next 10.3
Additional Comments
https://gyazo.com/fc2916dd34f3dcd120ae1c9874764515
The text was updated successfully, but these errors were encountered: