Added Hebrew language and first RTL template #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattaschmann
pushed a commit
to mattaschmann/best-resume-ever
that referenced
this pull request
Mar 9, 2020
…late salomonelli#8) Added Hebrew language and first RTL template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
I've added a new language file for Hebrew and added the first RTL template(#8) based on side-bar template. I simply called it side-bar-rtl.
Another thing is that the import's path on
resumes.jswas unnecessary. I changed it toimport './NAME.vue';instead ofimport '../resumes/NAME.vue';.In order to check the RTL alignment correctly, you can use this
person.jsfile.This PR was made for #HacktoberfestTLV