Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templates for Right to Left #8

Closed
msarsha opened this issue Sep 10, 2017 · 8 comments
Closed

Templates for Right to Left #8

msarsha opened this issue Sep 10, 2017 · 8 comments
Labels
help wanted new template

Comments

@msarsha
Copy link

msarsha commented Sep 10, 2017

No description provided.

@salomonelli
Copy link
Owner

What does RTL mean?

@msarsha
Copy link
Author

msarsha commented Sep 10, 2017

Right to Left

@eladcandroid
Copy link

To support languages like Hebrew, Arabic etc..

@salomonelli
Copy link
Owner

I see ... A PR for template supporting rtl is welcome and highly appreciated!

@salomonelli salomonelli reopened this Sep 12, 2017
@salomonelli salomonelli changed the title Any plans to support RTL? Templates for Right to Left Sep 13, 2017
@lielfr
Copy link
Contributor

lielfr commented Sep 19, 2017

Hi! I'm planning to work on it. Should it be as new templates or included within the existing ones?

@salomonelli
Copy link
Owner

Hi @lielfr, please just create new templates.

@yoavmmn
Copy link
Contributor

yoavmmn commented Oct 3, 2017

@salomonelli I'm planning to work on this as well. It'd be great if you'd assigned it to me.

@yoavmmn yoavmmn mentioned this issue Oct 5, 2017
Merged
@yoavmmn
Copy link
Contributor

yoavmmn commented Oct 5, 2017

I've added the first RTL template based on side-bar template. you can check it out at #83.

@lielfr lielfr mentioned this issue Oct 14, 2017
Closed
salomonelli added a commit that referenced this issue Oct 18, 2017
@salomonelli
Merge pull request #83 from yoavmmn/side-bar-rtl (RTL template #8)
0c8530b 
Added Hebrew language and first RTL template
mattaschmann pushed a commit to mattaschmann/best-resume-ever that referenced this issue Mar 9, 2020
@salomonelli
Merge pull request salomonelli#83 from yoavmmn/side-bar-rtl (RTL temp…
b33b74c 
…late salomonelli#8)

Added Hebrew language and first RTL template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted new template
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lielfr @msarsha @yoavmmn @salomonelli @eladcandroid