-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusion matrix branch #549
Conversation
* update confusion_matrix * cla * fix deserialization
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
===========================================
+ Coverage 0 86.80% +86.80%
===========================================
Files 0 347 +347
Lines 0 12026 +12026
Branches 0 403 +403
===========================================
+ Hits 0 10439 +10439
- Misses 0 1587 +1587
Continue to review full report at Codecov.
|
core/src/main/scala/com/salesforce/op/evaluators/OpMultiClassificationEvaluator.scala
Show resolved
Hide resolved
lgtm @swkasula |
@swkasula can we add a test to confirm the serialization/deserialization is working? That would probably belong in the ModelSelectorSummaryTest |
That's a good point, will add it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@swkasula I removed the Snyk checks from the repo which cleared them from this PR |
Related issues
De-serializing the ConfMatrices: Seq[Seq[Long]] resulting in ClassCastException as there was no @JsonDeserialize
annotation used for this attribute: https://github.com/salesforce/TransmogrifAI/pull/533/files
Describe the proposed solution
Fix is it update the ConfMatrices format from Seq[Seq[Long]] -> Seq[ConfusionMatrixPerThreshold] to de-serialize in the right format
Copy of: #545