Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion matrix branch #549

Merged
merged 7 commits into from
Mar 15, 2021
Merged

Confusion matrix branch #549

merged 7 commits into from
Mar 15, 2021

Conversation

swkasula
Copy link
Collaborator

@swkasula swkasula commented Mar 11, 2021

Related issues
De-serializing the ConfMatrices: Seq[Seq[Long]] resulting in ClassCastException as there was no @JsonDeserialize
annotation used for this attribute: https://github.com/salesforce/TransmogrifAI/pull/533/files

Describe the proposed solution
Fix is it update the ConfMatrices format from Seq[Seq[Long]] -> Seq[ConfusionMatrixPerThreshold] to de-serialize in the right format

Copy of: #545

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #549 (c16fb91) into master (975eb2f) will increase coverage by 86.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #549       +/-   ##
===========================================
+ Coverage        0   86.80%   +86.80%     
===========================================
  Files           0      347      +347     
  Lines           0    12026    +12026     
  Branches        0      403      +403     
===========================================
+ Hits            0    10439    +10439     
- Misses          0     1587     +1587     
Impacted Files Coverage Δ
...op/evaluators/OpMultiClassificationEvaluator.scala 95.80% <100.00%> (ø)
...a/com/salesforce/op/filters/RawFeatureFilter.scala 92.97% <0.00%> (ø)
...ain/scala/com/salesforce/op/aggregators/Text.scala 100.00% <0.00%> (ø)
...s/impl/feature/DecisionTreeNumericBucketizer.scala 94.73% <0.00%> (ø)
...rce/op/stages/impl/feature/HumanNameDetector.scala 95.55% <0.00%> (ø)
...rc/main/scala/com/salesforce/op/stages/HasIn.scala 100.00% <0.00%> (ø)
...mpl/regression/OpGeneralizedLinearRegression.scala 76.92% <0.00%> (ø)
...tages/impl/preparators/SanityCheckerMetadata.scala 89.86% <0.00%> (ø)
...stages/impl/feature/DropIndicesByTransformer.scala 100.00% <0.00%> (ø)
utils/src/main/scala/com/salesforce/op/UID.scala 91.66% <0.00%> (ø)
... and 338 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975eb2f...c16fb91. Read the comment docs.

@feifjiang
Copy link
Contributor

lgtm @swkasula

@crupley
Copy link
Contributor

crupley commented Mar 11, 2021

@swkasula can we add a test to confirm the serialization/deserialization is working? That would probably belong in the ModelSelectorSummaryTest

@swkasula
Copy link
Collaborator Author

@swkasula can we add a test to confirm the serialization/deserialization is working? That would probably belong in the ModelSelectorSummaryTest

That's a good point, will add it.

Copy link
Contributor

@crupley crupley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swkasula
Copy link
Collaborator Author

swkasula commented Mar 12, 2021

@crupley @tovbinm @nicodv Could you please assist on how the below required checks can be completed to proceed to merge the PR:
security/snyk (Salesforce OSS )
license/snyk (Salesforce OSS

Copy link
Contributor

@nicodv nicodv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amateurhuman
Copy link

@swkasula I removed the Snyk checks from the repo which cleared them from this PR

@swkasula swkasula merged commit 44a5dce into master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants