Update confusion_matrix

[swkasula]

Related issues
De-serializing the ConfMatrices: Seq[Seq[Long]] resulting in ClassCastException as there was no @JsonDeserialize
annotation used for this attribute: https://github.com/salesforce/TransmogrifAI/pull/533/files

Describe the proposed solution
Fix is it update the ConfMatrices format from Seq[Seq[Long]] -> Seq[ConfusionMatrixPerThreshold] to de-serialize in the right format

[salesforce-cla]

Thanks for the contribution! It looks like @swkasula is an internal user so signing the CLA is not required. However, we need to confirm this.

[codecov]

Codecov Report

Merging #545 (012e20d) into master (975eb2f) will increase coverage by 86.78%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #545       +/-   ##
===========================================
+ Coverage        0   86.78%   +86.78%     
===========================================
  Files           0      347      +347     
  Lines           0    12026    +12026     
  Branches        0      403      +403     
===========================================
+ Hits            0    10437    +10437     
- Misses          0     1589     +1589     

Impacted Files	Coverage Δ
...op/evaluators/OpMultiClassificationEvaluator.scala	95.80% <100.00%> (ø)
...e/op/stages/impl/feature/SmartTextVectorizer.scala	95.33% <0.00%> (ø)
...com/salesforce/op/local/OpWorkflowModelLocal.scala	100.00% <0.00%> (ø)
...force/op/stages/impl/feature/OpStringIndexer.scala	100.00% <0.00%> (ø)
.../stages/impl/feature/OpStringIndexerNoFilter.scala	100.00% <0.00%> (ø)
...com/salesforce/op/test/PassengerFeaturesTest.scala	90.00% <0.00%> (ø)
...ala/com/salesforce/op/readers/CSVAutoReaders.scala	100.00% <0.00%> (ø)
...a/com/salesforce/op/test/OpPipelineStageSpec.scala	97.95% <0.00%> (ø)
...la/com/salesforce/op/stages/OpPipelineStages.scala	63.88% <0.00%> (ø)
...ain/scala/com/salesforce/op/cli/SchemaSource.scala	87.93% <0.00%> (ø)
... and 338 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975eb2f...012e20d. Read the comment docs.

[tovbinm]

Thanks, @swkasula

Please confirm the OSS agreement.

[crupley]

minor style issue: params are typically lower camel case:

Suggested change

	Threshold: Double,
	@JsonDeserialize(contentAs = classOf[java.lang.Long])
	ConfusionMatrixCounts: Seq[Long]
	threshold: Double,
	@JsonDeserialize(contentAs = classOf[java.lang.Long])
	confusionMatrixCounts: Seq[Long]

[feifjiang]

Can you add a line here verifying the threshold? Something like outputMetrics.ConfMatrices(0).Threshold shouldEqual....

[feifjiang]

same as above. Otherwise lgtm

[swkasula]

closing this as I created a different PR: #549 to merge from the tested dev branch.