Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved datetime unit transformer shortcuts - Part 2 #319

Merged
merged 28 commits into from
May 20, 2019
Merged

Improved datetime unit transformer shortcuts - Part 2 #319

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
8ee8410
add time period conversion shortcuts
crupley Apr 30, 2019
b80302c
move time period transformers into trait
crupley Apr 30, 2019
668074d
remove trait
crupley May 12, 2019
0ae7a3b
add test
crupley May 12, 2019
b741d5f
create common class and update test
crupley May 12, 2019
d92ab72
restore line
crupley May 12, 2019
ccd5291
remove unused import
crupley May 13, 2019
02627ff
Merge remote-tracking branch 'upstream/master' into cr/timeperiod
crupley May 13, 2019
56351da
Merge branch 'master' into cr/timeperiod
tovbinm May 13, 2019
b785401
Merge branch 'master' into cr/timeperiod
tovbinm May 13, 2019
e43ce7e
switch to dedicated unary transformer and new test
crupley May 14, 2019
76eb332
use shortcut in test
crupley May 14, 2019
86b8df0
Merge remote-tracking branch 'upstream/master' into cr/timeperiod
crupley May 14, 2019
6d12c9b
Merge branch 'cr/timeperiod' of github.com:crupley/TransmogrifAI into…
crupley May 14, 2019
4bb13c5
restore blank line
crupley May 14, 2019
5f91f14
add header
crupley May 14, 2019
191cd15
convert periodFun to function
crupley May 14, 2019
d777d17
add header
crupley May 14, 2019
08d1e25
add time period support for list and map date types
crupley May 14, 2019
d6796f7
Merge remote-tracking branch 'upstream/master' into cr/timeperiod-redux
crupley May 14, 2019
e02d174
update
crupley May 14, 2019
dc3a857
clean up
crupley May 14, 2019
1d00d76
fix style
crupley May 15, 2019
32b8098
add test of transformer shortcuts
crupley May 16, 2019
54f6f49
Merge remote-tracking branch 'upstream/master' into cr/timeperiod-redux
crupley May 16, 2019
7745506
Merge branch 'master' into cr/timeperiod-redux
tovbinm May 16, 2019
db5efad
address PR comments
crupley May 16, 2019
b46f3d8
Merge branch 'cr/timeperiod-redux' of github.com:crupley/TransmogrifA…
crupley May 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix style
  • Loading branch information
@crupley
crupley committed May 15, 2019
commit 1d00d761494420bdfe37c02b1306b82037a84810
3 changes: 2 additions & 1 deletion core/src/test/scala/com/salesforce/op/stages/impl/feature/TimePeriodMapTransformerTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ class TimePeriodMapTransformerTest extends OpTransformerSpec[IntegralMap, TimePe

val (inputData, f1) = TestFeatureBuilder(Seq[DateMap](dateMap))

override val transformer: TimePeriodMapTransformer[DateMap] = new TimePeriodMapTransformer(TimePeriod.DayOfMonth).setInput(f1)
override val transformer: TimePeriodMapTransformer[DateMap] =
new TimePeriodMapTransformer(TimePeriod.DayOfMonth).setInput(f1)

override val expectedResult: Seq[IntegralMap] = Seq(
names.zip(Seq(14L, 12L, 8L, 30L)).toMap.toIntegralMap
Expand Down