Improved datetime unit transformer shortcuts - Part 2 #319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 86.44% 82.61% -3.83%
==========================================
Files 327 329 +2
Lines 10602 10608 +6
Branches 336 533 +197
==========================================
- Hits 9165 8764 -401
- Misses 1437 1844 +407
Continue to review full report at Codecov.
|
| uid: String = UID[TimePeriodTransformer[_]] | ||
| )( | ||
| implicit override val tti: TypeTag[I] | ||
| ) extends UnaryTransformer[I, OPVector](operationName = "dateToTimePeriod", uid = uid) { |
There was a problem hiding this comment.
please use a different and distinctive operation name, say dateListToTimePeriod
| uid: String = UID[TimePeriodTransformer[_]] | ||
| )( | ||
| implicit override val tti: TypeTag[I] | ||
| ) extends UnaryTransformer[I, IntegralMap](operationName = "dateToTimePeriod", uid = uid) { |
There was a problem hiding this comment.
please use a different and distinctive operation name, say dateMapToTimePeriod
| ) extends UnaryTransformer[I, OPVector](operationName = "dateToTimePeriod", uid = uid) { | ||
|
|
||
| override def transformFn: I => OPVector = | ||
| (i: I) => i.value.map(t => period.extractFromTime(t).toDouble).toVector.toOPVector |
There was a problem hiding this comment.
why i.value.map(t => period.extractFromTime(t).toDouble).toOPVector does not work?
| class TimePeriodListTransformer[I <: DateList] | ||
| ( | ||
| val period: TimePeriod, | ||
| uid: String = UID[TimePeriodTransformer[_]] |
There was a problem hiding this comment.
fix uid - UID[TimePeriodListTransformer[_]]
| class TimePeriodMapTransformer[I <: DateMap] | ||
| ( | ||
| val period: TimePeriod, | ||
| uid: String = UID[TimePeriodTransformer[_]] |
There was a problem hiding this comment.
same here - fix uid - UID[TimePeriodMapTransformer[_]]
Related issues
Improved datetime unit transformer shortcuts #315
Part 1: #316
Describe the proposed solution
Add additional time period support for
mapandlistdate/datetime feature types.TimePeriodMapTransformerTimePeriodListTransformertoTimePeriodshortcuts inRich-{DateList/DateTimeList/DateMap/DateTimeMap}Describe alternatives you've considered
None
Additional context
None