Add ifnull method to db abstraction layer #8811
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow business hours to calculate when possible
Signed-off-by: Dillon-Brown <[email protected]>
…ield() Don't use array_keys() twice and fix typo in variable name '$panelId'.
strip out entries for email and newsletter does not work for non-english speaking users
expected 'Customer','Prospect' but returns 'Customer\\',\\'Prospect' because $ db->quote is applied twice if strpos($args[$i], ',') !== false, leading to a wrong result Also, $enable = false leads to an error as $db is not defined in that case
Add css for case updates textarea to allow horizontal resize
Always group by the main group by field to prevent duplicate groups is cases where the main group by field is not grouped in the report
in_array() expects parameter 2 to be array, null given in rebuild Undefined index: SERVER_SOFTWARE in install_utils.php
getModuleField is called twice with the same parameters
Remove and replace legacy Reports with AOR_Reports
language files are fr_FR.js and de_DE.js These files are not found because the file loaded is strtolower($GLOBALS['current_language']) .js That might happen for all other languages where language contains capital letters.
On custom fields with the required attribute not set, can throw a notice
Task Status key is displayed instead of label in View History (so, it is not using translation)
- Revert "Fixed salesagility#7696 - Folder "include/SugarCharts/Jit" missing in 7.11.7 installation" This reverts commit 7e21c58. - Revert "Fix travis JIT failure" This reverts commit b761318. - Revert "Remove JIT" This reverts commit f4764ed.
DBManager::concat is not defined as static. It generates a PHP error: Call to undefined method Contact::quoted() in XXX/include/database/DBManager.php on line 1818
…matting Change Depreciation log to more appropriate Info log
Remove redundant function dirInArray
Update query to be compatible with SQL server, reduce 6 hours to 2
prevent 500 error when manifest is missing ior cannot be read
…field Change TinyMCE to be instance specific
…se sqlserver bug)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ifnull method to db abstraction.
Description
After PR 7428 regression raised on ms sql server driver, as ifnull does not supported on this DB.
To reproduce the issue just connect to SuiteCRM with ms sql server db.
Motivation and Context
mysql ifnull used in audit and it does not support in sql server.
How To Test This
Just configure your DB, and go change log of one of the entities with existing history.
Types of changes
Final checklist