-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDAPAutheticate warnings in log #3911
Comments
@halest can you please try this change and see if it solves the issue for you? (now updated with the missing parenthesis) |
Make sure you also include () after PARAMS = Array |
@pgorod Thank you for the effort. I have been playing around with the commits and it seems the least-amount-of-change-solution to get rid of the warnings while keeping it functional would be to change the function declarations like so: So good on my end |
@Dillon-Brown can you please add a commit to your PR with
|
After change: |
@erikschwalbe actually I think that warning is a sign of a bug: the order of the parameters in that I believe probably what was intended in that line was this:
Click to check out in_array syntax. @Dillon-Brown what do you think? |
Issue
Updated to latest release yesterday evening, now have 15k lines of warnings in Log:
PHP Warning: Declaration of LDAPAuthenticateUser::loadUserOnLogin($name, $password) should be compatible with SugarAuthenticateUser::loadUserOnLogin($name, $password, $fallback = false, $PARAMS = Array) in C:\inetpub\suitecrm\modules\Users\authentication\LDAPAuthenticate\LDAPAuthenticateUser.php on line 52
Declaration of LDAPAuthenticateUser::authenticateUser($name, $password) should be compatible with SugarAuthenticateUser::authenticateUser($name, $password, $fallback = false) in C:\inetpub\suitecrm\modules\Users\authentication\LDAPAuthenticate\LDAPAuthenticateUser.php on line 52
Anyone know how to fix this?
Context
Your Environment
The text was updated successfully, but these errors were encountered: