Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON config upload #7256

Open
wants to merge 992 commits into
base: hotfix-7.10.x
Choose a base branch
from
Open

Fix JSON config upload #7256

wants to merge 992 commits into from

Conversation

robertalv
Copy link

@robertalv robertalv commented May 5, 2019

Description

Fixed application upload to json

Motivation and Context

Allows Upload Google API Credentials File to be selected.

How To Test This

Test with text/plain and then test with application/json,.json

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

gymad and others added 30 commits January 10, 2019 15:22
# Conflicts:
#	.travis.yml
#	composer.lock
#	include/LangText.php
#	include/Sugarpdf/Sugarpdf.php
#	include/dir_inc.php
#	include/nusoap/class.soap_server.php
#	modules/AOD_Index/Lib/Zend/Search/Lucene/Storage/File/Filesystem.php
#	modules/Campaigns/WebToPersonCapture.php
#	modules/Emails/Dashlets/MyEmailsDashlet/MyEmailsDashlet.data.php
#	modules/Emails/Email.php
#	modules/Emails/EmailUI.php
#	modules/Emails/EmailsController.php
#	modules/Emails/Save.php
#	modules/Emails/Status.php
#	modules/Emails/field_arrays.php
#	modules/Emails/include/ListView/ListViewDataEmails.php
#	modules/Emails/include/ListView/ListViewDataEmailsSearchOnCrm.php
#	modules/Emails/include/ListView/ListViewDataEmailsSearchOnIMap.php
#	modules/InboundEmail/InboundEmail.php
#	modules/UpgradeWizard/uw_utils.php
#	tests/unit/phpunit/modules/Emails/EmailTest.php
#	themes/SuiteP/css/Dawn/style.css
#	themes/SuiteP/css/Day/style.css
#	themes/SuiteP/css/Dusk/style.css
#	themes/SuiteP/css/Night/style.css
In #6329 mozaik was set to a dummy object to make it work when not using
the mozaik editor. But the added variable declaration shadows the global
variable breaking the case where mozaik is actually used, setting it to
undefined.

This breaks inserting images into emails, the file gets uploaded but the
URL field stays empty.

Fix this by explicitly checking if we are using mozaik instead of using
a dummy object.
# Conflicts:
#	README.md
#	suitecrm_version.php
Fixed #6484 - Fix image insertion with mozaik
unit tests: force enable E_ALL in bootstrap
Fixed #6758 - [language]Duplicated language strings - develop branch
This solution worked for us and others users. 

Originally posted by @michelhcote in 729e22a#commitcomment-31947648
code-ph0y and others added 20 commits April 5, 2019 17:07
Fixed 6761 - Api/V8 - Unable to Delete (unlink) relationships
Fixed #6862 - API - Custom Routes file is stored separately from other custom files
Fix custom fields in sort/filter in the API
Change default view on template to avoid date created/modified issues
Fixed #5724 - Map Area - Import Option Fails : An Error has occurred
Fixed #7162 - Popup select All records btn hidden in SuiteCRM 7.11.x
#6126 fix(Workflow AnyChange condition) - decode prev value before compare
…ge_10

# Conflicts:
#	.travis.yml
#	README.md
#	composer.json
#	composer.lock
#	include/Smarty/plugins/function.sugar_button.php
#	modules/Users/reassignUserRecords.php
#	service/v4_1/SugarWebServiceUtilv4_1.php
#	suitecrm_version.php
#	tests/unit/phpunit/data/SugarBeanTest.php
…lasticsearch

Fixed #6540 - Hard coded text to language files
Fixed #6829 - Cache composer packages on Travis CI
…ge_10

# Conflicts:
#	composer.json
#	composer.lock
#	include/InlineEditing/InlineEditing.php
#	include/SugarObjects/templates/basic/metadata/detailviewdefs.php
#	modules/AOW_WorkFlow/AOW_WorkFlow.php
#	modules/InboundEmail/InboundEmail.php
#	service/core/SugarWebServiceImpl.php
#	service/v2_1/SugarWebServiceImplv2_1.php
#	service/v3_1/SugarWebServiceImplv3_1.php
#	service/v4/SugarWebServiceImplv4.php
fixed bug that removes Email_Address_Removed_In_Email_Body if email i…
fixing a recursion issue on reminders
@robertalv
Copy link
Author

Signed CLAHub.

@Dillon-Brown Dillon-Brown added PR:Community Contribution These are contribution made by the community PR:Wrong Branch Pull requests that point towards a restricted branch such as master labels May 6, 2019
@Dillon-Brown
Copy link
Contributor

Hi @robertalv, would you be able to remake this for the hotfix-7.10.x branch? thanks.

code-ph0y and others added 4 commits May 23, 2019 14:19
@Dillon-Brown Dillon-Brown changed the base branch from master to hotfix-7.10.x May 30, 2019 09:07
@SuiteBot
Copy link

SuiteBot commented Aug 27, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 9 committers have signed the CLA.

✅ Dillon-Brown
✅ JimMackin
✅ samus-aran
✅ urdhvatech
✅ cameronblaikie
❌ gymad
❌ janderson
❌ code-ph0y
❌ robertalv


janderson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Community Contribution These are contribution made by the community PR:Wrong Branch Pull requests that point towards a restricted branch such as master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet