Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If field value contains single quote, on each save CRM will treat this field as a changed #6126

Closed
re8260 opened this issue Jul 5, 2018 · 5 comments
Closed

If field value contains single quote, on each save CRM will treat this field as a changed #6126

re8260 opened this issue Jul 5, 2018 · 5 comments
Labels
Area: Module Issues & PRs related to modules that do not have specific label Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds Type: Bug Bugs within the core SuiteCRM codebase
Milestone
7.10.8

Comments

@re8260
Copy link
Contributor

re8260 commented Jul 5, 2018

Issue

If field value contains single quote, on each save CRM will treat this field as a changed even if the value was not changed.

Expected Behavior

If value was not changed, nothing should happen.

Actual Behavior

  1. Run all Workflows with condition Any Change on this field.
  2. Add new line to bean change log, same value before and after
    image
    image

Possible Fix

The problem happen because the prev value from $bean->fetched_row['name'] in encoded as html and actual value is not encoded so they will nevet be same : R'oman vs R'oman
image

Steps to Reproduce

  1. Create Account with single quote in name
  2. Create WorkFlow with condition AnyChange on Account name field
  3. Open and save bean with chnages
  4. in result, new line will be added to change-log and Workflow will be trigger

Context

lint to test Workflow 89c58469-90fc-c629-a607-5b3e14312651
link to test account bean 3dedfaf4-8387-91ce-7113-5b3e0c9f6119

high priority

Your Environment

Demo Envierment Version 7.10.7
https://demo.suiteondemand.com
@gunnicom
Copy link
Contributor

gunnicom commented Jul 5, 2018

Maybe this one:
#1094

@re8260
Copy link
Contributor Author

re8260 commented Jul 5, 2018 •
edited
Loading

@gunnicom thanks.
This patch #1094 doesn't fix my change-log issue, and it doesn't care about Workflow AnyChange.

Screenshot with patch from #1094
image

I pushed new MR to fix change-log: #6127

@re8260 re8260 mentioned this issue Jul 5, 2018
Merged
6 tasks
@gunnicom
Copy link
Contributor

gunnicom commented Jul 5, 2018

Ah, i missed the workflow part in your report. Ok, then these are two bugs.

re8260 added a commit to re8260/SuiteCRM that referenced this issue Jul 5, 2018
@re8260
salesagility#6126 fix(Workflow) - decode prev value before compare in…
b76fca4 
… workflow AnyChange condition
@re8260 re8260 mentioned this issue Jul 5, 2018
Merged
6 tasks
@re8260
Copy link
Contributor Author

re8260 commented Jul 5, 2018

@gunnicom
MR that fix WF: #6128

@Dillon-Brown Dillon-Brown added Type: Bug Bugs within the core SuiteCRM codebase Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds Area: Module Issues & PRs related to modules that do not have specific label labels Jul 11, 2018
gymad pushed a commit that referenced this issue Jul 27, 2018
@re8260
#6126 fix(Change-log) - decode prev value before compare
07871f6
gymad added a commit that referenced this issue Jul 27, 2018
@gymad
Merge pull request #6127 from re8260/v7.10.5_singlequote_changelog
9174528 
#6126 fix(Change-log) - decode prev value before compare
@samus-aran samus-aran added this to the 7.10.8 milestone Aug 1, 2018
@re8260
Copy link
Contributor Author

re8260 commented Sep 17, 2018

@Dillon-Brown this MR #6128 relate to the same issue but it even more important and critical

re8260 added a commit to re8260/SuiteCRM that referenced this issue Nov 18, 2018
@re8260
salesagility#6126 fix(Workflow) - decode current value before compare…
30b2a3a 
… in workflow AnyChange condition (Bug exist only on bean delete action\)
Dillon-Brown added a commit to Dillon-Brown/SuiteCRM that referenced this issue Mar 7, 2019
@Dillon-Brown
07871f6 salesagility#6126 fix(Change-log) - decode prev value before …
42e3909 
…compare
samus-aran added a commit that referenced this issue Apr 23, 2019
@samus-aran
Merge pull request #6128 from re8260/v7.10.5_singlequote_workflow
a781c2c 
#6126 fix(Workflow AnyChange condition) - decode prev value before compare
Dillon-Brown added a commit to Dillon-Brown/SuiteCRM that referenced this issue Apr 29, 2019
@Dillon-Brown
salesagility#6126 fix(Workflow) - decode prev value before compare in…
6bb30d8 
… workflow AnyChange condition
Dillon-Brown added a commit to Dillon-Brown/SuiteCRM that referenced this issue Apr 29, 2019
@Dillon-Brown
salesagility#6126 fix(Workflow) - decode prev value before compare in…
4da4a8d 
… workflow AnyChange condition
pgorod added a commit to pgorod/SuiteCRM that referenced this issue Jun 9, 2019
@pgorod
Hotfix 7.8.x (#5)
8afecbe 
* Fixed salesagility#994 - Address Translation

* Fix For salesagility#1866 Display module by alphabetical order

* Update to remove duplicate string

* Replace removed EmailMarketing Key

* Fixed salesagility#2400 - Language manifest is duplicated and overwritten on each new language install

* Pass order_by to getBeans() params on getRelationshipResults()

* Add util function to load a class from /custom if it exists

* Check for custom MassUpdate file before loading the class

* Refactor

* Add path parameter default value

* Fix salesagility#5971 - Send email with Workflow using Meetings module breaks parent_id

* Fixed salesagility#5967 - AOR Reports - incorrect calculation for date quarter periods

* Improve where clause when removing securitygroups relationships.

* Fixed salesagility#6285 - LBL_DBCONFIG_B_MSG1_LABEL empty string

* php_zip_utils.php

* Add logging

* Bug fix create language cache in multilanguage system

* Mass update on user preferences doesn't save

Moved code from save.php to user.php and deleted save.php removed calls
to deleted file in controller.php

* Fix require for removed file

* replacing mbcryp_cbc with openssl_encrypt for SOAP key over LDAP

* Fixed salesagility#6414 - Bug in modules/Schedulers/_AddJobsHere.php

* Update cipher

* Pack buffer

* OPENSSL_NO_PADDING

* Update rebuild htaccess

* Fix handling of Account names and ids in Leads

* remove left-over debug line

* Fixed salesagility#6516 - (filler) elements in layouts are removed by gridlayout parser

* Fixed salesagility#2928 Fixed salesagility#341 - clear Zend OPcache when writing files

* Brackets set wrong

* Brackets et wrong

* Brackets wrong

* Brackets wrong

* Default navigation paradigm should be used

It is useless if it is not used, and then default defaults to group modules.

* Workflow Date - Remove incorrect branch when unserialize fails

* Time issue fixed in email template for datetime fields

* Change hard coded labels in Events invites

* PipelineBySalesStageDashlet not converting currency

* Fix for Edit View

* Panel tab fix

* Import mapping publish button

* markTestIncomplete: testderiveDBDateTimes

* markTestIncomplete

* fixing task 3624

* FIX salesagility#6568 - Adjust SUITECRM_PHP_REC_VERSION to 7.1.0

* Fix salesagility#6579 - Calendar daily repeat end by

- Fix: extra meeting created after end by date

* Remove die

* Better this way to avoid warnings

* Increment suitecrm_version.php

* Fixed salesagility#6570 -Case description not saving when AJAX is disabled

* Added tintMCE to description field in the Edit View

* cleaning

* Fixed salesagility#163 - Pagination bar in Emails

* work for all themes

* requested changes for Matt done

* Fix conflicts

* Update License

* Update License

* Fixed salesagility#5509 - [language] New label 'FOR_AMOUNT' in activity stream for opportunity

* Use LoggerManager class instead of accessing global

* modified require_once to relative dir and to the top of the file

* Try to resolve Travis Build for hotfix-7.8.x

* Fix conflicts

* Update License

* Update License

* Fixed salesagility#5509 - [language] New label 'FOR_AMOUNT' in activity stream for opportunity

* Fixed salesagility#163 - Pagination bar in Emails

* fixing travis

* apply only change to the head

* Generate chart colors based on labels

This way it is easier to identify the colour of the label you are looking for.
Superseeds salesagility#1536 and salesagility#6638

* escaping strings

* cs fix

* copy pr salesagility#6629 into hotfix

* Fixed installWizard styling - check writable module

* php cs fix

* fixing indentation

* code refact after salesagility#6647 merged

* Fixed salesagility#532 - Add the edit/remove button to Project Tasks subpanel

* Fixed salesagility#5968 - AOR Reports - incorrect start date calculated for LastQuarter period when in the 4th quarter

* Fix salesagility#4361 Parameter $imageJSONEncode should also be used if returning sprites.

Fix salesagility#4361
Parameter $imageJSONEncode should also be used if returning sprites.

* Style.css + JS

* Increment suitecrm_version

* Fixed salesagility#5414 - Password is not saving

* Fix user save

* Fix user save

* Fixed - salesagility#6766 - SMTP Port Issue (7.8.x)

* Fixed salesagility#6786 -  Edit item list replace spaces with html entity "%20"(7.8.25)

* Update SimpleList.js

* Fixed salesagility#6468 - Wrong WHERE composition upon NULL precondition in Company

* WIP: Fix regression breaking Accounts detail view

* Increment suitecrm_version

* Linter

* Fixed salesagility#675 - Suitecrm 7.3.2 Calendar entries are not displayed

* Fixed salesagility#6423 - after upgrading 7.8.13 to 7.8.22 getting Invalid File Reference from attachments in inbound

* Update .travis.yml

* Fixed salesagility#551 - add functionality to save new labels for relationships

* Fixed salesagility#6419 - Reserved mssql keyword in query, crash business hours module

* Remove debugger

* Fixed salesagility#5918 - Activity Stream elapsed time calculation

* Fix test

* Fixed salesagility#6936 - Global link Employees always reset list query

* Fixed salesagility#2117 - Redundant More Button in SuiteP

* Typo fix

* Increment suitecrm_version

* Fix for checkbox in PDF

* Cleaning

* Cleaning

* V2

* Clear

* Fix PDF templates

* Update templateParser.php

* Fixed salesagility#6971 - Function removed instead of being Deprecated

* Reformat

* Fixed salesagility#2531 - 7.10.4 - Report Writer - Boolean FIeld will not export to CSV

* Fixed salesagility#6185 - Top menu mouse out does not close sub

* FIX salesagility#7032 - Add setLevelMapping method

* Increase minimum recommended memory to 64Mb

* Update templateParser.php

* FIX salesagility#7051 - Fixing a limit of 2.147.483 seconds for autoRefresh

* Fixed salesagility#7067 - InLine Date Edit bug - Call to a member function format() on boolean

* Fixed salesagility#3592 - AOR Report- Date parameter doesn't work with any value of type 'Period'

* Fixed salesagility#4297 - Error in Listview : Pagination - Bulk Action disabled and wrong "Selected" count

* Fix: for merge request 25

* Increment suitecrm_version

* Fixed salesagility#48 - install.php issue

* Fixed salesagility#49 - popup_helper.js

* Rebuild JS

* Fixed salesagility#46 - reassignUserRecords

* Fix bug_7220

* Change default view on template to avoid date created/modified issues

* Fixed salesagility#5724 - Map Area - Import Option Fails : An Error has occurred

* salesagility#6126 fix(Workflow) - decode prev value before compare in workflow AnyChange condition

* Fixed salesagility#6037 - Reports: Fix adding relations from the first tree node

* Fixed salesagility#7162 - Popup select All records btn hidden in SuiteCRM 7.11.x

* Update composer.lock

* InboundEmail.php

* reassignUserRecords.php

* version 7.8.29

* Add return to function

Did not find at which point it was fixed for 7.10, but should be backportet to 7.8.x

https://github.com/salesagility/SuiteCRM/blob/1892b13ecfcd9a9e3cd575c8b4b3336188e86f28/include/SubPanel/SubPanelDefinitions.php#L432

* Fixed install syntax error

* Events fix

* Fixed salesagility#7133 - Changes in Studio do not make an override file.

* increment suitecrm_version

* Remove PHP 5.4

* Update travis.yml

* Use trusty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Module Issues & PRs related to modules that do not have specific label Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds Type: Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Milestone
7.10.8
Development

No branches or pull requests
5 participants
@gunnicom @samus-aran @re8260 @Dillon-Brown @Mac-Rae