Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding show_completed argument to iCall #3897

Open
wants to merge 61 commits into
base: develop
Choose a base branch
from

Conversation

sanchezfauste
Copy link
Contributor

Adding show_completed argument to iCall to be able to hide the completed Meetings, Calls and Tasks.

Description

Adding a parameter to specify if the completed tasks, meetings and calls have to be present to the returned icall. By default this parameter is true.

Motivation and Context

We think that showing the completed tasks in the calendar is not so useful when there are a lot of tasks. It would be very useful if you can choose if you want to see the completed tasks or not.

How To Test This

Obtain iCall without completed tasks, meetings and calls: https://crm.example.com/ical_server.php?type=ics&key=XXX&email=YYY&show_tasks_as_events=true&show_completed=false

Obtain iCall including completed tasks, meetings and calls: https://crm.example.com/ical_server.php?type=ics&key=XXX&email=YYY&show_tasks_as_events=true&show_completed=true

or simply:

https://crm.example.com/ical_server.php?type=ics&key=XXX&email=YYY&show_tasks_as_events=true

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@Dillon-Brown
Copy link
Contributor

Hi @sanchezfauste You still need to sign the Clahub Contributor License Agreement.

@sanchezfauste
Copy link
Contributor Author

Thank you @Dillon-Brown, I have signed the Contributor License.

gymad
gymad previously approved these changes Apr 23, 2018
@cameronblaikie cameronblaikie added the PR:Community Contribution These are contribution made by the community label Dec 3, 2018
Dillon-Brown and others added 18 commits January 2, 2019 10:02
* Update command to allow for cache directory specified in config
* Remove warnings/errors when no cached directory present
* Update to have namespace "cache" so we can add other cache commands later
  * Leave alias for current command
* Use provided toolsets required by robo for implementation
* Print cleaned directories
* Confirm before cleaning directory
  * Allow for force override
…-notes

# Conflicts:
#	modules/Campaigns/Campaign.php
#	modules/Campaigns/views/view.detail.php
#	modules/Notes/vardefs.php
…gn-notes

Add ability to have Notes on a Campaign
@Mac-Rae
Copy link
Contributor

Mac-Rae commented Aug 5, 2019

Please resolve the conflicts on this pull request bringing it up to date.

@Mac-Rae Mac-Rae added the Status:Requires Updates Issues & PRs which requires input or update from the author label Aug 5, 2019
@sanchezfauste
Copy link
Contributor Author

Please resolve the conflicts on this pull request bringing it up to date.

Done.

@Dillon-Brown Dillon-Brown removed the Status:Requires Updates Issues & PRs which requires input or update from the author label Aug 5, 2019
@Dillon-Brown Dillon-Brown added the Status:Needs Documentation Requires adding documentation label Nov 22, 2019
@SuiteBot
Copy link

SuiteBot commented Aug 27, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
6 out of 7 committers have signed the CLA.

✅ sanchezfauste
✅ Dillon-Brown
✅ samus-aran
✅ isleshocky77
✅ lazka
✅ cameronblaikie
❌ code-ph0y
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Community Contribution These are contribution made by the community Status:Needs Documentation Requires adding documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants