-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding show_completed argument to iCall #3897
base: develop
Are you sure you want to change the base?
Adding show_completed argument to iCall #3897
Conversation
Hi @sanchezfauste You still need to sign the Clahub Contributor License Agreement. |
Thank you @Dillon-Brown, I have signed the Contributor License. |
65d0682
to
95f8224
Compare
fix last page when modulus is zero
Fixed salesagility#6720 - Remove old recaptcha files
* Update command to allow for cache directory specified in config * Remove warnings/errors when no cached directory present * Update to have namespace "cache" so we can add other cache commands later * Leave alias for current command * Use provided toolsets required by robo for implementation * Print cleaned directories * Confirm before cleaning directory * Allow for force override
…-notes # Conflicts: # modules/Campaigns/Campaign.php # modules/Campaigns/views/view.detail.php # modules/Notes/vardefs.php
…gn-notes Add ability to have Notes on a Campaign
# Conflicts: # composer.json # composer.lock
# Conflicts: # composer.json # composer.lock
Fixed salesagility#4511 - Upgrade of TinyMCE to latest 4.9.x version
Fixes salesagility#7111 - composer: include mpdf/mpdf 6.1 and drop in-tree version (5.7)
Fixed salesagility#7027 - Use a maintained library to minify JS
# Conflicts: # composer.json # composer.lock
# Conflicts: # composer.lock
Please resolve the conflicts on this pull request bringing it up to date. |
Done. |
|
1998a13
to
7e9bf41
Compare
Adding show_completed argument to iCall to be able to hide the completed Meetings, Calls and Tasks.
Description
Adding a parameter to specify if the completed tasks, meetings and calls have to be present to the returned icall. By default this parameter is true.
Motivation and Context
We think that showing the completed tasks in the calendar is not so useful when there are a lot of tasks. It would be very useful if you can choose if you want to see the completed tasks or not.
How To Test This
Obtain iCall without completed tasks, meetings and calls: https://crm.example.com/ical_server.php?type=ics&key=XXX&email=YYY&show_tasks_as_events=true&show_completed=false
Obtain iCall including completed tasks, meetings and calls: https://crm.example.com/ical_server.php?type=ics&key=XXX&email=YYY&show_tasks_as_events=true&show_completed=true
or simply:
https://crm.example.com/ical_server.php?type=ics&key=XXX&email=YYY&show_tasks_as_events=true
Types of changes
Final checklist