Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #7027 - Use a maintained library to minify JS #7295

Merged
merged 5 commits into from
May 23, 2019

Conversation

Dillon-Brown
Copy link
Contributor

@Dillon-Brown Dillon-Brown commented May 17, 2019

Description

Part of my ongoing efforts to remove manually included libraries and replace them with composer packages. This PR replaces the outdated tedious/JShrink and instead loads an updated version with composer. I've also re-minified the existing JS files using the updated library.

Motivation and Context

Issue reference: #7027

How To Test This

  1. Run JS repairs in admin panel.
  2. Check that minified JS works as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@codecov-io
Copy link

Codecov Report

Merging #7295 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #7295      +/-   ##
=============================================
+ Coverage      10.83%   10.84%   +<.01%     
+ Complexity     42148    42086      -62     
=============================================
  Files           3377     3376       -1     
  Lines         248096   247933     -163     
=============================================
  Hits           26886    26886              
+ Misses        221210   221047     -163

@cameronblaikie
Copy link
Contributor

Assessed 👍

@cameronblaikie
Copy link
Contributor

Assessed 👍

@cameronblaikie cameronblaikie merged commit 7973c8c into salesagility:develop May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants