Derive `Eq` and `Hash` for `ControlFlow` #103084

inquisitivecrystal · 2022-10-15T10:16:27Z

There's really no reason for ControlFlow not to derive these traits. This is the part of #96416 that no one objected to, but that PR seems stale. The Eq derive was also requested by @lcnr on Zulip to allow for pattern matching.

This change requires an FCP because it's insta-stable.

Closes #96416.

rustbot · 2022-10-15T10:16:30Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-10-15T10:16:30Z

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

joshtriplett · 2022-10-15T13:47:34Z

@rfcbot merge

rfcbot · 2022-10-15T13:47:35Z

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

library/core/src/ops/control_flow.rs

scottmcm · 2022-10-15T20:57:44Z

The Eq derive was also requested by @lcnr on Zulip to allow for pattern matching.

I'll cross-link #102697 (comment) here, since libs-api seems skeptical of the CONTINUE constant, which would weaken the motivation slightly.

(I still think this PR is worth doing, though.)

joshtriplett · 2022-10-16T13:26:18Z

I still think Eq and Hash have value.

inquisitivecrystal · 2022-10-17T13:05:40Z

Quick request: I want to clean up the comment a bit before this actually gets merged. I hope to get to that in the next day or two. The only way a merge could happen before then is if people were quick with approvals and someone decided it wasn't worth waiting the full ten days, but I thought I'd put in the request just in case. :)

BurntSushi · 2022-10-17T13:10:37Z

So for me, I suspect these are useful and that we should have them.

But I am a tiny bit skeptical of their utility, and conceptually, I do somewhat wonder what it means to "compare" two different "control flow" values. But maybe I am being too conservative here. And in particular, I can't think of anything specifically bad about these impls, although I do question in what use cases they are useful. (Beyond the, e.g., CONTINUE constant, which I am more skeptical about for already stated reasons.)

There is a part of me that would like to hold off on stabilizing these impls until ControlFlow itself has been stable for a bit and we can get a better idea of how it's actually used. But I don't feel strong enough to register a concern if others are confident that this is totally fine.

scottmcm · 2022-10-17T19:26:13Z

until ControlFlow itself has been stable for a bit

Note that ControlFlow the type has been stable for about a year now: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1550-2021-09-09

(Some of its associated stuff is still unstable, though.)

inquisitivecrystal · 2022-10-17T19:55:01Z

But I am a tiny bit skeptical of their utility, and conceptually, I do somewhat wonder what it means to "compare" two different "control flow" values. But maybe I am being too conservative here. And in particular, I can't think of anything specifically bad about these impls, although I do question in what use cases they are useful. (Beyond the, e.g., CONTINUE constant, which I am more skeptical about for already stated reasons.)

When you say "compare", that makes me think of PartialOrd and Ord, which aren't being proposed. Equality comparisons are already allowed, since we implement PartialEq. This really isn't allowing any new operations, in terms of the semantics of the type.

I think we really ought to add the Eq derivation, just on the grounds of being a good neighbor. It's a marker trait: since equality comparisons on this type are total equality comparisons, it makes sense to mark them as such. In addition, there's no reason to prevent users from creating their own constants and using them in matches, even if we end up removing CONTINUE.

I don't actually have a use case in mind for Hash, but I'm not sure we really need one. Just to give a general direction, a use for this might involve memoization or the like. Result already implements Hash, so this is does provide parity with that.

Unlike PartialOrd and Ord, these operations are consistent with the operations that are already meaningful for the type. They just make it more interoperable and pleasant to use. As a final point, the Rust API guidelines say that types should eagerly implement common traits. If these operations are meaningful, the question becomes why we wouldn't want to add them.

Sorry for going into "passionately list all the reasons why we should totally do this" mode. Bad habit of mine.

BurntSushi · 2022-10-17T19:55:13Z

@scottmcm Oh! For some reason I lumped it in with Try being unstable.

I'd say my concern is very weak then. Weak enough to tick my box.

BurntSushi · 2022-10-17T19:56:45Z

Equality comparisons are already allowed, since we implement PartialEq.

Ah okay, I didn't realize this either. I buy it.

rfcbot · 2022-10-19T11:12:08Z

🔔 This is now entering its final comment period, as per the review above. 🔔

inquisitivecrystal · 2022-10-19T20:29:47Z

Quick request: I want to clean up the comment a bit before this actually gets merged. I hope to get to that in the next day or two.

Done!

rfcbot · 2022-10-29T11:17:13Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

scottmcm · 2022-11-01T23:40:43Z

FCP complete; this is good to go!

@bors r+

bors · 2022-11-01T23:40:45Z

📌 Commit 4a92cf6 has been approved by scottmcm

It is now in the queue for this repository.

…earth Rollup of 8 pull requests Successful merges: - rust-lang#103072 (compiletest: set the dylib path when gathering target cfg) - rust-lang#103084 (Derive `Eq` and `Hash` for `ControlFlow`) - rust-lang#103575 (Change #[suggestion_*] attributes to use style="...") - rust-lang#103637 (Use stdio in UWP apps) - rust-lang#103638 (Add `multivalue` target feature to WASM target) - rust-lang#103781 (Detect unused files in `src/test/mir-opt` and error on them in tidy.) - rust-lang#103837 (Migrate sidebar-links-color GUI test to functions) - rust-lang#103839 (Print valid `--print` requests if request is invalid) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Pkgsrc changes: * Adjust patches and cargo checksums to new versions, but also one strange "mips" conditional. Upstream changes: Version 1.67.0 (2023-01-26) ========================== Language -------- - [Make `Sized` predicates coinductive, allowing cycles.] (rust-lang/rust#100386) - [`#[must_use]` annotations on `async fn` also affect the `Future::Output`.] (rust-lang/rust#100633) - [Elaborate supertrait obligations when deducing closure signatures.] (rust-lang/rust#101834) - [Invalid literals are no longer an error under `cfg(FALSE)`.] (rust-lang/rust#102944) - [Unreserve braced enum variants in value namespace.] (rust-lang/rust#103578) Compiler -------- - [Enable varargs support for calling conventions other than `C` or `cdecl`.] (rust-lang/rust#97971) - [Add new MIR constant propagation based on dataflow analysis.] (rust-lang/rust#101168) - [Optimize field ordering by grouping m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) - [Stabilize native library modifier `verbatim`.] (rust-lang/rust#104360) Added and removed targets: - [Add a tier 3 target for PowerPC on AIX] (rust-lang/rust#102293), `powerpc64-ibm-aix`. - [Add a tier 3 target for the Sony PlayStation 1] (rust-lang/rust#102689), `mipsel-sony-psx`. - [Add tier 3 `no_std` targets for the QNX Neutrino RTOS] (rust-lang/rust#102701), `aarch64-unknown-nto-qnx710` and `x86_64-pc-nto-qnx710`. - [Remove tier 3 `linuxkernel` targets] (rust-lang/rust#104015) (not used by the actual kernel). Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Merge `crossbeam-channel` into `std::sync::mpsc`.] (rust-lang/rust#93563) - [Fix inconsistent rounding of 0.5 when formatted to 0 decimal places.] (rust-lang/rust#102935) - [Derive `Eq` and `Hash` for `ControlFlow`.] (rust-lang/rust#103084) - [Don't build `compiler_builtins` with `-C panic=abort`.] (rust-lang/rust#103786) Stabilized APIs --------------- - [`{integer}::checked_ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog) - [`{integer}::checked_ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog2) - [`{integer}::checked_ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog10) - [`{integer}::ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog) - [`{integer}::ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog2) - [`{integer}::ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog10) - [`NonZeroU*::ilog2`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog2) - [`NonZeroU*::ilog10`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog10) - [`NonZero*::BITS`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#associatedconstant.BITS) These APIs are now stable in const contexts: - [`char::from_u32`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_u32) - [`char::from_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_digit) - [`char::to_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_digit) - [`core::char::from_u32`] (https://doc.rust-lang.org/stable/core/char/fn.from_u32.html) - [`core::char::from_digit`] (https://doc.rust-lang.org/stable/core/char/fn.from_digit.html) Compatibility Notes ------------------- - [The layout of `repr(Rust)` types now groups m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) This is intended to be an optimization, but it is also known to increase type sizes in a few cases for the placement of enum tags. As a reminder, the layout of `repr(Rust)` types is an implementation detail, subject to change. - [0.5 now rounds to 0 when formatted to 0 decimal places.] (rust-lang/rust#102935) This makes it consistent with the rest of floating point formatting that rounds ties toward even digits. - [Chains of `&&` and `||` will now drop temporaries from their sub-expressions in evaluation order, left-to-right.] (rust-lang/rust#103293) Previously, it was "twisted" such that the _first_ expression dropped its temporaries _last_, after all of the other expressions dropped in order. - [Underscore suffixes on string literals are now a hard error.] (rust-lang/rust#103914) This has been a future-compatibility warning since 1.20.0. - [Stop passing `-export-dynamic` to `wasm-ld`.] (rust-lang/rust#105405) - [`main` is now mangled as `__main_void` on `wasm32-wasi`.] (rust-lang/rust#105468) - [Cargo now emits an error if there are multiple registries in the configuration with the same index URL.] (rust-lang/cargo#10592) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Rewrite LLVM's archive writer in Rust.] (rust-lang/rust#97485)

Pkgsrc changes: * Adjust patches (add & remove) and cargo checksums to new versions. * It's conceivable that the workaround for LLVM based NetBSD works even less in this version (ref. PKGSRC_HAVE_LIBCPP not having a corresponding patch anymore). Upstream changes: Version 1.68.2 (2023-03-28) =========================== - [Update the GitHub RSA host key bundled within Cargo] (rust-lang/cargo#11883). The key was [rotated by GitHub] (https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/) on 2023-03-24 after the old one leaked. - [Mark the old GitHub RSA host key as revoked] (rust-lang/cargo#11889). This will prevent Cargo from accepting the leaked key even when trusted by the system. - [Add support for `@revoked` and a better error message for `@cert-authority` in Cargo's SSH host key verification] (rust-lang/cargo#11635) Version 1.68.1 (2023-03-23) =========================== - [Fix miscompilation in produced Windows MSVC artifacts] (rust-lang/rust#109094) This was introduced by enabling ThinLTO for the distributed rustc which led to miscompilations in the resulting binary. Currently this is believed to be limited to the -Zdylib-lto flag used for rustc compilation, rather than a general bug in ThinLTO, so only rustc artifacts should be affected. - [Fix --enable-local-rust builds] (rust-lang/rust#109111) - [Treat `$prefix-clang` as `clang` in linker detection code] (rust-lang/rust#109156) - [Fix panic in compiler code] (rust-lang/rust#108162) Version 1.68.0 (2023-03-09) =========================== Language -------- - [Stabilize default_alloc_error_handler] (rust-lang/rust#102318) This allows usage of `alloc` on stable without requiring the definition of a handler for allocation failure. Defining custom handlers is still unstable. - [Stabilize `efiapi` calling convention.] (rust-lang/rust#105795) - [Remove implicit promotion for types with drop glue] (rust-lang/rust#105085) Compiler -------- - [Change `bindings_with_variant_name` to deny-by-default] (rust-lang/rust#104154) - [Allow .. to be parsed as let initializer] (rust-lang/rust#105701) - [Add `armv7-sony-vita-newlibeabihf` as a tier 3 target] (rust-lang/rust#105712) - [Always check alignment during compile-time const evaluation] (rust-lang/rust#104616) - [Disable "split dwarf inlining" by default.] (rust-lang/rust#106709) - [Add vendor to Fuchsia's target triple] (rust-lang/rust#106429) - [Enable sanitizers for s390x-linux] (rust-lang/rust#107127) Libraries --------- - [Loosen the bound on the Debug implementation of Weak.] (rust-lang/rust#90291) - [Make `std::task::Context` !Send and !Sync] (rust-lang/rust#95985) - [PhantomData layout guarantees] (rust-lang/rust#104081) - [Don't derive Debug for `OnceWith` & `RepeatWith`] (rust-lang/rust#104163) - [Implement DerefMut for PathBuf] (rust-lang/rust#105018) - [Add O(1) `Vec -> VecDeque` conversion guarantee] (rust-lang/rust#105128) - [Leak amplification for peek_mut() to ensure BinaryHeap's invariant is always met] (rust-lang/rust#105851) Stabilized APIs --------------- - [`{core,std}::pin::pin!`] (https://doc.rust-lang.org/stable/std/pin/macro.pin.html) - [`impl From<bool> for {f32,f64}`] (https://doc.rust-lang.org/stable/std/primitive.f32.html#impl-From%3Cbool%3E-for-f32) - [`std::path::MAIN_SEPARATOR_STR`] (https://doc.rust-lang.org/stable/std/path/constant.MAIN_SEPARATOR_STR.html) - [`impl DerefMut for PathBuf`] (https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#impl-DerefMut-for-PathBuf) These APIs are now stable in const contexts: - [`VecDeque::new`] (https://doc.rust-lang.org/stable/std/collections/struct.VecDeque.html#method.new) Cargo ----- - [Stabilize sparse registry support for crates.io] (rust-lang/cargo#11224) - [`cargo build --verbose` tells you more about why it recompiles.] (rust-lang/cargo#11407) - [Show progress of crates.io index update even `net.git-fetch-with-cli` option enabled] (rust-lang/cargo#11579) Misc ---- Compatibility Notes ------------------- - [Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` to future-incompat report] (rust-lang/rust#103418) - [Only specify `--target` by default for `-Zgcc-ld=lld` on wasm] (rust-lang/rust#101792) - [Bump `IMPLIED_BOUNDS_ENTAILMENT` to Deny + ReportNow] (rust-lang/rust#106465) - [`std::task::Context` no longer implements Send and Sync] (rust-lang/rust#95985) nternal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Encode spans relative to the enclosing item] (rust-lang/rust#84762) - [Don't normalize in AstConv] (rust-lang/rust#101947) - [Find the right lower bound region in the scenario of partial order relations] (rust-lang/rust#104765) - [Fix impl block in const expr] (rust-lang/rust#104889) - [Check ADT fields for copy implementations considering regions] (rust-lang/rust#105102) - [rustdoc: simplify JS search routine by not messing with lev distance] (rust-lang/rust#105796) - [Enable ThinLTO for rustc on `x86_64-pc-windows-msvc`] (rust-lang/rust#103591) - [Enable ThinLTO for rustc on `x86_64-apple-darwin`] (rust-lang/rust#103647) Version 1.67.0 (2023-01-26) ========================== Language -------- - [Make `Sized` predicates coinductive, allowing cycles.] (rust-lang/rust#100386) - [`#[must_use]` annotations on `async fn` also affect the `Future::Output`.] (rust-lang/rust#100633) - [Elaborate supertrait obligations when deducing closure signatures.] (rust-lang/rust#101834) - [Invalid literals are no longer an error under `cfg(FALSE)`.] (rust-lang/rust#102944) - [Unreserve braced enum variants in value namespace.] (rust-lang/rust#103578) Compiler -------- - [Enable varargs support for calling conventions other than `C` or `cdecl`.] (rust-lang/rust#97971) - [Add new MIR constant propagation based on dataflow analysis.] (rust-lang/rust#101168) - [Optimize field ordering by grouping m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) - [Stabilize native library modifier `verbatim`.] (rust-lang/rust#104360) Added and removed targets: - [Add a tier 3 target for PowerPC on AIX] (rust-lang/rust#102293), `powerpc64-ibm-aix`. - [Add a tier 3 target for the Sony PlayStation 1] (rust-lang/rust#102689), `mipsel-sony-psx`. - [Add tier 3 `no_std` targets for the QNX Neutrino RTOS] (rust-lang/rust#102701), `aarch64-unknown-nto-qnx710` and `x86_64-pc-nto-qnx710`. - [Remove tier 3 `linuxkernel` targets] (rust-lang/rust#104015) (not used by the actual kernel). Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Merge `crossbeam-channel` into `std::sync::mpsc`.] (rust-lang/rust#93563) - [Fix inconsistent rounding of 0.5 when formatted to 0 decimal places.] (rust-lang/rust#102935) - [Derive `Eq` and `Hash` for `ControlFlow`.] (rust-lang/rust#103084) - [Don't build `compiler_builtins` with `-C panic=abort`.] (rust-lang/rust#103786) Stabilized APIs --------------- - [`{integer}::checked_ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog) - [`{integer}::checked_ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog2) - [`{integer}::checked_ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog10) - [`{integer}::ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog) - [`{integer}::ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog2) - [`{integer}::ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog10) - [`NonZeroU*::ilog2`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog2) - [`NonZeroU*::ilog10`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog10) - [`NonZero*::BITS`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#associatedconstant.BITS) These APIs are now stable in const contexts: - [`char::from_u32`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_u32) - [`char::from_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_digit) - [`char::to_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_digit) - [`core::char::from_u32`] (https://doc.rust-lang.org/stable/core/char/fn.from_u32.html) - [`core::char::from_digit`] (https://doc.rust-lang.org/stable/core/char/fn.from_digit.html) Compatibility Notes ------------------- - [The layout of `repr(Rust)` types now groups m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) This is intended to be an optimization, but it is also known to increase type sizes in a few cases for the placement of enum tags. As a reminder, the layout of `repr(Rust)` types is an implementation detail, subject to change. - [0.5 now rounds to 0 when formatted to 0 decimal places.] (rust-lang/rust#102935) This makes it consistent with the rest of floating point formatting that rounds ties toward even digits. - [Chains of `&&` and `||` will now drop temporaries from their sub-expressions in evaluation order, left-to-right.] (rust-lang/rust#103293) Previously, it was "twisted" such that the _first_ expression dropped its temporaries _last_, after all of the other expressions dropped in order. - [Underscore suffixes on string literals are now a hard error.] (rust-lang/rust#103914) This has been a future-compatibility warning since 1.20.0. - [Stop passing `-export-dynamic` to `wasm-ld`.] (rust-lang/rust#105405) - [`main` is now mangled as `__main_void` on `wasm32-wasi`.] (rust-lang/rust#105468) - [Cargo now emits an error if there are multiple registries in the configuration with the same index URL.] (rust-lang/cargo#10592) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Rewrite LLVM's archive writer in Rust.] (rust-lang/rust#97485)

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 15, 2022

rust-highfive assigned thomcc Oct 15, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2022

joshtriplett removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 15, 2022

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Oct 15, 2022

scottmcm reviewed Oct 15, 2022

View reviewed changes

library/core/src/ops/control_flow.rs Outdated Show resolved Hide resolved

inquisitivecrystal assigned joshtriplett and unassigned thomcc Oct 16, 2022

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 19, 2022

Derive Eq and Hash for ControlFlow

4a92cf6

inquisitivecrystal force-pushed the control-flow branch from 4a4f384 to 4a92cf6 Compare October 19, 2022 20:28

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 29, 2022

rfcbot added the to-announce Announce this issue on triage meeting label Oct 29, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2022

Manishearth mentioned this pull request Nov 2, 2022

Rollup of 8 pull requests #103857

Merged

bors merged commit d4bd794 into rust-lang:master Nov 2, 2022

rustbot added this to the 1.67.0 milestone Nov 2, 2022

apiraino removed the to-announce Announce this issue on triage meeting label Jan 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Derive `Eq` and `Hash` for `ControlFlow` #103084

Derive `Eq` and `Hash` for `ControlFlow` #103084

inquisitivecrystal commented Oct 15, 2022 •

edited

Loading

rustbot commented Oct 15, 2022

rust-highfive commented Oct 15, 2022

joshtriplett commented Oct 15, 2022

rfcbot commented Oct 15, 2022 •

edited by m-ou-se

Loading

scottmcm commented Oct 15, 2022

joshtriplett commented Oct 16, 2022 •

edited

Loading

inquisitivecrystal commented Oct 17, 2022 •

edited

Loading

BurntSushi commented Oct 17, 2022

scottmcm commented Oct 17, 2022

inquisitivecrystal commented Oct 17, 2022 •

edited

Loading

BurntSushi commented Oct 17, 2022

BurntSushi commented Oct 17, 2022

rfcbot commented Oct 19, 2022

inquisitivecrystal commented Oct 19, 2022

rfcbot commented Oct 29, 2022

scottmcm commented Nov 1, 2022

bors commented Nov 1, 2022

Derive Eq and Hash for ControlFlow #103084

Derive Eq and Hash for ControlFlow #103084

Conversation

inquisitivecrystal commented Oct 15, 2022 • edited Loading

rustbot commented Oct 15, 2022

rust-highfive commented Oct 15, 2022

joshtriplett commented Oct 15, 2022

rfcbot commented Oct 15, 2022 • edited by m-ou-se Loading

scottmcm commented Oct 15, 2022

joshtriplett commented Oct 16, 2022 • edited Loading

inquisitivecrystal commented Oct 17, 2022 • edited Loading

BurntSushi commented Oct 17, 2022

scottmcm commented Oct 17, 2022

inquisitivecrystal commented Oct 17, 2022 • edited Loading

BurntSushi commented Oct 17, 2022

BurntSushi commented Oct 17, 2022

rfcbot commented Oct 19, 2022

inquisitivecrystal commented Oct 19, 2022

rfcbot commented Oct 29, 2022

scottmcm commented Nov 1, 2022

bors commented Nov 1, 2022

Derive `Eq` and `Hash` for `ControlFlow` #103084

Derive `Eq` and `Hash` for `ControlFlow` #103084

inquisitivecrystal commented Oct 15, 2022 •

edited

Loading

rfcbot commented Oct 15, 2022 •

edited by m-ou-se

Loading

joshtriplett commented Oct 16, 2022 •

edited

Loading

inquisitivecrystal commented Oct 17, 2022 •

edited

Loading

inquisitivecrystal commented Oct 17, 2022 •

edited

Loading