Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop parsing ui_test annotations in run-dep mode #2969

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Stop parsing ui_test annotations in run-dep mode #2969

merged 4 commits into from
Jul 7, 2023

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 6, 2023

fixes #2967

RalfJung
RalfJung reviewed Jul 6, 2023
View reviewed changes
tests/compiletest.rs Outdated Show resolved Hide resolved
@oli-obk oli-obk force-pushed the run-dep branch 2 times, most recently from 1458518 to a9d2ba8 Compare July 6, 2023 10:56
oli-obk
oli-obk commented Jul 6, 2023
View reviewed changes
tests/compiletest.rs Outdated Show resolved Hide resolved
RalfJung
RalfJung reviewed Jul 6, 2023
View reviewed changes
tests/compiletest.rs Outdated Show resolved Hide resolved
RalfJung
RalfJung reviewed Jul 6, 2023
View reviewed changes
tests/compiletest.rs Outdated Show resolved Hide resolved
@RalfJung
Copy link
Member

RalfJung commented Jul 7, 2023

Looks good, thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Jul 7, 2023

📌 Commit bf96df4 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 7, 2023

⌛ Testing commit bf96df4 with merge 2aeb232...

@bors
Copy link
Collaborator

bors commented Jul 7, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 2aeb232 to master...

@bors bors merged commit 2aeb232 into rust-lang:master Jul 7, 2023
7 checks passed
@RalfJung
Copy link
Member

RalfJung commented Jul 7, 2023 •
edited
Loading

Output is not fully identical yet:

$ ./miri run-dep tests/pass/hello.rs
   Building test dependencies...
Hello, world!

Should we hide that Building test dependencies... as well?

@oli-obk oli-obk deleted the run-dep branch July 7, 2023 17:36
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 7, 2023

Yea, but that has to happen on the ui_test side. I'm working on simplifying the API (now that I got a bunch of users of it), so that --quiet and friends are automatically handled and affect these kind of outputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

./miri run-dep parses ui-test comments
3 participants
@oli-obk @RalfJung @bors