Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./miri run-dep parses ui-test comments #2967

Closed
RalfJung opened this issue Jul 5, 2023 · 2 comments · Fixed by oli-obk/ui_test#93 or #2969
Closed

./miri run-dep parses ui-test comments #2967

RalfJung opened this issue Jul 5, 2023 · 2 comments · Fixed by oli-obk/ui_test#93 or #2969

Comments

@RalfJung
Copy link
Member

RalfJung commented Jul 5, 2023

Title says it all: running ./miri run-dep shouldn't care about whether the ui-test comments in the file make sense, they should just all be ignored. But currently when working on a test I am getting errors like

$ ./miri run-dep tests/fail/shims/memcpy_zero.rs
    Finished dev [optimized + debuginfo] target(s) in 0.01s
    Finished dev [optimized + debuginfo] target(s) in 0.01s
     Running `target/debug/cargo-miri miri setup --print-sysroot`
    Finished test [optimized + debuginfo] target(s) in 0.02s
     Running tests/compiletest.rs (target/debug/deps/compiletest-abb37bc11260f53d)
   Building test dependencies...
Error: 
   0: [
          InvalidComment {
              msg: "no pattern specified",
              line: 9,
          },
      ]

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
error: test failed, to rerun pass `--test compiletest`
@oli-obk
Copy link
Contributor

oli-obk commented Jul 6, 2023

What about //@ comments that are necessary to run the test?

@RalfJung
Copy link
Member Author

RalfJung commented Jul 6, 2023

Not sure what you mean? compile-flags etc should all be ignored. The input to ./miri run and ./miri run-dep is just a Rust file, it's meant to be like rustc file.rs but for Miri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants