build: fix wrong repo urls, clippies #480
Conversation
|
So less than 3d ago there was some protoc related update which broke it's invocation. Seems unlikely but I guess there are some lenient versions in some Cargo.toml. Cannot reproduce locally with my old Cargo.lock or without one. Having hard time believing |
|
prost-build v0.8.0 is attempting to use the bundled protoc which for some reason cannot be found. This is really odd; the package should not have been cached by rust-cache in the first place because only metadata of the crates is cached, and few days ago there was no issue. It's as if something changed in github during that time. I can still try to hotfix this by setting it to use the system protoc... but that would only work on Linux, at least easily. Strangely enough this wasn't a problem during a build which failed because of bad npm url https://github.com/rs-ipfs/rust-ipfs/runs/4391953703?check_suite_focus=true#step:9:153 ... I'll have to postpone solving this, could also be a transient GHA issue. |
|
Fresh cache helped, but node needs to be downgraded as well I guess. |
this includes a change on making `unixfs::InvalidCidInLink` properly `#[non_exhaustive]` instead of using the hidden field trick. it probably isn't a breaking change, but then again requires a more recent rustc, which sort of makes it a breaking change.
these query types were originally observing what kind of requests conformance tests do and what kind of requests go-ipfs supports, so keeping them as there might be some value. to be removed when upgrading conformance tests.
assorted unused or idiomatic changes.
this probably makes sense in the future if ipns dht records ever become supported.
koivunej
changed the title
|
Force pushing this soon with less churn around the protoc, which I still think shouldn't be needed at all. However it's possible the bundling is behind a feature flag I just couldn't see. |
|
Okay, this is widly confusing how things have just "fixed themselves", meaning mostly the protoc issues commented earlier. bors r+ |
|
Build succeeded: |
I had forgotten some old urls there which are sure to cause build failures, as seen in the #479.