-
Notifications
You must be signed in to change notification settings - Fork 164
Return time since connection if no round trip yet #479
Conversation
I gave this a quick look and it seems great, thanks for doing this! I was thinking that maybe the one of the existing hashmaps could perhaps be used for this but ... That would then complicate other things. The connection tracking parts are a bit overdue for proper cleanup and moving upwards to rust-libp2p. There's now some npm related breakage but the build failing at that step means that the (few) rust tests passed. Oki, it's most likely because I have forgotten an old url there. I'll probably handle this on a separate PR. Could you take care of the rustfmt issue? Just do a There's another issue after you fix the rustfmt issue with protoc missing, will be handling that in #480 the same. |
Oops |
Happy to discuss tracking the time of a connection in rust-libp2p. Feel free to open an issue on https://github.com/libp2p/rust-libp2p/. |
480: build: fix wrong repo urls, clippies r=koivunej a=koivunej I had forgotten some old urls there which are sure to cause build failures, as seen in the #479. Co-authored-by: Joonas Koivunen <[email protected]>
Thanks for this @jmmaloney4. I have to admit I forgot about this PR while hustling the #480, apologies for that. I've rebased this on top of the latest master. The second commit was not needed anymore so it was dropped, and I simplified with the use of It looks like conformance tests agree, so I'll push a changelog entry and merge this. Thanks again. |
bors r+ |
479: Return time since connection if no round trip yet r=koivunej a=jmmaloney4 Fixes #178. Co-authored-by: Jack Maloney <[email protected]> Co-authored-by: Joonas Koivunen <[email protected]>
I will try to remember this and apologies on the late reply once more for you as well. I think the big cleanup is overdue with me really understanding the |
Build failed: |
bors retry |
479: Return time since connection if no round trip yet r=koivunej a=jmmaloney4 Fixes #178. Co-authored-by: Jack Maloney <[email protected]> Co-authored-by: Joonas Koivunen <[email protected]>
Build failed: |
Well, this is ackward. bors retry |
479: Return time since connection if no round trip yet r=koivunej a=jmmaloney4 Fixes #178. Co-authored-by: Jack Maloney <[email protected]> Co-authored-by: Joonas Koivunen <[email protected]>
Well, it would appear that gha is having some issues now with the bad credentials issue. I'll try again later. |
Build failed: |
bors retry |
Build succeeded: |
Fixes #178.