Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement merging of new key material when importing pubkeys #3083

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Implement merging of new key material when importing pubkeys #3083

wants to merge 7 commits into from

Commits on May 8, 2024

  1. Fix error handling in rpmtsImportPubkey 

    The call to pgpPubKeyLint() modified the rc code, which the
following code assumed to be RPMRC_FAIL.

Also, the return code of the database operation was always
overwritten with RPMRC_OK.
    @mlschroe
    mlschroe committed May 8, 2024
    Configuration menu
    Copy the full SHA
    4621abc View commit details
    Browse the repository at this point in the history

  2. Make subkeys available right away when a pubkey is imported 

    This is useful for API users that do not re-read the keys
from the database.
    @mlschroe
    mlschroe committed May 8, 2024
    Configuration menu
    Copy the full SHA
    0872648 View commit details
    Browse the repository at this point in the history

  3. Split subkey initialization into its own function 

    No functual changes.
    @mlschroe
    mlschroe committed May 8, 2024
    Configuration menu
    Copy the full SHA
    5926604 View commit details
    Browse the repository at this point in the history

  4. Add rpmKeyringModify to change the keys of a keyring 

    This allows us to replace or delete keys from the keyring.
    @mlschroe
    mlschroe committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2292bb2 View commit details
    Browse the repository at this point in the history

  5. Add a method to lookup a key from the keyring 

    Use this method in rpmtsImportPubkey() to check if we already
have that key. This is the place where we will implement key
merging in the next commits.
    @mlschroe
    mlschroe committed May 8, 2024
    Configuration menu
    Copy the full SHA
    8ac10de View commit details
    Browse the repository at this point in the history

  6. Support pubkey merging in the keyring code 

    The new rpmPubkeyMerge function will merge the certificate
material of two pubkeys describing the same key.

This is currently only implemented in the "legcay" backend.
    @mlschroe
    mlschroe committed May 8, 2024
    Configuration menu
    Copy the full SHA
    885a3ab View commit details
    Browse the repository at this point in the history

  7. Merge keys and update the database in rpmtsImportPubkey()

    @mlschroe
    mlschroe committed May 8, 2024
    Configuration menu
    Copy the full SHA
    028d84b View commit details
    Browse the repository at this point in the history