Implement merging of new key material when importing pubkeys #3083
Conversation
The call to pgpPubKeyLint() modified the rc code, which the following code assumed to be RPMRC_FAIL. Also, the return code of the database operation was always overwritten with RPMRC_OK.
This is useful for API users that do not re-read the keys from the database.
No functual changes.
This allows us to replace or delete keys from the keyring.
Use this method in rpmtsImportPubkey() to check if we already have that key. This is the place where we will implement key merging in the next commits.
The new rpmPubkeyMerge function will merge the certificate material of two pubkeys describing the same key. This is currently only implemented in the "legcay" backend.
|
Oh, nice. Didn't look at details yet but the functionality is pretty desperately needed indeed. @nwalfield , thoughts from rpm-sequoia POV (or otherwise)? |
I'll take a look the start of next week. From a very high-level perspective: yes, we want to merge certificates. So, thanks a lot for working on this @mlschroe! |
@mlschroe , I didn't quite expect you to start so actively hacking on it, more like terminal care and hence the name. If you intend to continue developing it, I'm okay with renaming it to something else than "legacy". Only it can't be "internal" anymore because it's not 😅 |
|
I started fixing some problems I found in the code and then got carried away... |
|
maybe "pgp" would be a working name for the backend... |
This currently only makes a difference if the "legacy" backend is used.