Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate the PR templates #28747

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Consolidate the PR templates #28747

merged 1 commit into from
Mar 19, 2021

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented Mar 19, 2021

Unfortunately although you can have multiple issue templates with a nice gui to select them. The PRs don't get that UI element.

Docs are here: https://docs.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository

Unfortunately although you can have multiple issue templates with a nice gui to select them. The PRs don't get that UI element.
@tfoote tfoote mentioned this pull request Mar 19, 2021
@tfoote tfoote requested a review from clalancette March 19, 2021 17:09
Copy link
Contributor

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this because it looks like a literal consolidation, but I have no idea how GitHub templates work, so someone else should check this as well.

@tfoote
Copy link
Member Author

tfoote commented Mar 19, 2021

I'm going to go ahead and merge this to see how it works. I don't think there's any way to tests it, and it's not working at the moment.

@tfoote tfoote merged commit 3761519 into ros:master Mar 19, 2021
@tfoote tfoote deleted the pr_template_merge branch March 19, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants