Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-semver #28676

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Conversation

aaronplusone
Copy link
Contributor

@aaronplusone aaronplusone requested a review from a team as a code owner March 17, 2021 19:45
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

One process question. Did you see the rosdep Pull Request template when you opened this PR?

@aaronplusone
Copy link
Contributor Author

aaronplusone commented Mar 17, 2021

One process question. Did you see the rosdep Pull Request template when you opened this PR?

I did not. Dialog was blank and I just looked at other PRs to see if there was a common format.

I assume it should've populated this?

@tfoote
Copy link
Member

tfoote commented Mar 17, 2021

Yeah, I'd like to get that prompt in so that everyone uses that. But clearly it's not popping up to make things easier. i'll have to look into cleaning that up.

@aaronplusone
Copy link
Contributor Author

Brief look I took, with multiple templates you need to modify the url query to include the template name. I didn't see anything in the CONTRIBUTING.md that indicated to use anything other than the github interface, and I didn't see anything in the PR interface that would allow switching templates like in gitlab.

Seems somewhat cumbersome to have to append ?template=rosdep_pull_request_template.md to the url when opening a PR, but I did confirm that the template populates when you do.

@tfoote
Copy link
Member

tfoote commented Mar 19, 2021

That's frustrating that it doesn't do the same thing as the issue templates with a prompt to select your template. Fix for that in #28747

@tfoote tfoote requested a review from a team March 19, 2021 01:50
@mabelzhang mabelzhang added the rosdep Issue/PR is for a rosdep key label Mar 23, 2021
Copy link
Contributor

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the Gentoo dependency [dev-python/semver], since it exists:
https://packages.gentoo.org/packages/dev-python/semver

@aaronplusone
Copy link
Contributor Author

Could you add the Gentoo dependency [dev-python/semver], since it exists:
https://packages.gentoo.org/packages/dev-python/semver

My knowledge of gentoo is pretty minimal. When testing in docker with gentoo/stage3, I ran into an issue with emerge dev-python/semver where the package was masked and required enabling a test branch. Is that typical?

5fcc6bcd120c / # emerge dev-python/semver

 * IMPORTANT: 6 news items need reading for repository 'gentoo'.
 * Use eselect news read to view new items.

Calculating dependencies... done!

!!! All ebuilds that could satisfy "dev-python/semver" have been masked.
!!! One of the following masked packages is required to complete your request:
- dev-python/semver-2.13.0::gentoo (masked by: ~amd64 keyword)

For more information, see the MASKED PACKAGES section in the emerge
man page or refer to the Gentoo Handbook.

5fcc6bcd120c / # export ACCEPT_KEYWORDS="~amd64"
5fcc6bcd120c / # emerge dev-python/semver

 * IMPORTANT: 6 news items need reading for repository 'gentoo'.
 * Use eselect news read to view new items.

Calculating dependencies... done!

>>> Verifying ebuild manifests

>>> Emerging (1 of 1) dev-python/semver-2.13.0::gentoo
...

Happy to add it, if so.

@tfoote
Copy link
Member

tfoote commented Mar 23, 2021

If there's a potential issue with it on gentoo lets skip it and let someone validate it and submit it.

@tfoote tfoote requested a review from wjwwood March 23, 2021 22:54
@wjwwood wjwwood merged commit 1ce7cca into ros:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants