Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rosdep rule for range-v3 library #23967

Merged
merged 3 commits into from
Mar 9, 2020
Merged

Add rosdep rule for range-v3 library #23967

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fc0073
Add rosdep rule for range-v3 library
miguelprada Mar 5, 2020
fdbdcfa
Specify supported Debian/Ubuntu distributions for range-v3
miguelprada Mar 9, 2020
5782974
Remove out-of-support distribution exceptions for range-v3
miguelprada Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Specify supported Debian/Ubuntu distributions for range-v3
  • Loading branch information
@miguelprada
miguelprada committed Mar 9, 2020
commit fdbdcfa953d92427210dd0428503c7fe86240922
11 changes: 9 additions & 2 deletions rosdep/base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4995,10 +4995,17 @@ r-base-dev:
gentoo: [dev-lang/R]
ubuntu: [r-base-dev]
range-v3:
debian: [librange-v3-dev]
debian:
'*': [librange-v3-dev]
jessie: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to add jessie here, as it is out-of-support.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it because it's one of the recommended supported platforms for Kinetic and I guessed it would be nice to include. It's gone now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we're a bit inconsistent there. We support these other Debian/Ubuntu versions when we first release the ROS distributions. Once they go out of support, we stop making changes to rosdep keys for them, but we don't remove them from the REP. Anyway, looks good to me now, thanks for iterating.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks for the explanation 👍

stretch: null
fedora: [range-v3]
gentoo: [dev-cpp/range-v3]
ubuntu: [librange-v3-dev]
ubuntu:
'*': [librange-v3-dev]
artful: null
wily: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for artful and wily; since they are out-of-support, we don't need to add exceptions for them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Added those because they were in the list of supported platforms for Kinetic (wily) and Melodic (artful). Also removed these.

xenial: null
rapidjson-dev:
debian: [rapidjson-dev]
fedora: [rapidjson]
Expand Down