Add rosdep rule for range-v3 library #23967
Conversation
rosdep/base.yaml
Outdated
| @@ -4994,6 +4994,11 @@ r-base-dev: | |||
| fedora: [R-devel] | |||
| gentoo: [dev-lang/R] | |||
| ubuntu: [r-base-dev] | |||
| range-v3: | |||
| debian: [librange-v3-dev] | |||
There was a problem hiding this comment.
This package is only available for debian buster and later. We still support debian stretch for Melodic, so this key will have to be more specific. See
Line 229 in 1cf2a02
There was a problem hiding this comment.
Marked as unavailable for jessie and stretch. The package is available in stretch-backports repository, but I guess that doesn't count, right?
There was a problem hiding this comment.
Correct, we can only depend on things in the main, security, universe, and multiverse repositories.
rosdep/base.yaml
Outdated
| debian: [librange-v3-dev] | ||
| fedora: [range-v3] | ||
| gentoo: [dev-cpp/range-v3] | ||
| ubuntu: [librange-v3-dev] |
There was a problem hiding this comment.
Same comment for ubuntu; this package is only available on eoan and later, but we still support xenial and bionic for Kinetic and Melodic, respectively. This key will need to be more specific.
There was a problem hiding this comment.
It's available for bionic as well.
|
Thanks for the review, @clalancette. I think I addressed your comments about the debian/ubuntu distribution specificity. Re. the fedora key: there's one there already, but I'm not sure that's correct. Should it be specified differnently? |
rosdep/base.yaml
Outdated
| range-v3: | ||
| debian: | ||
| '*': [librange-v3-dev] | ||
| jessie: null |
There was a problem hiding this comment.
We don't need to add jessie here, as it is out-of-support.
There was a problem hiding this comment.
I added it because it's one of the recommended supported platforms for Kinetic and I guessed it would be nice to include. It's gone now.
There was a problem hiding this comment.
Yeah, we're a bit inconsistent there. We support these other Debian/Ubuntu versions when we first release the ROS distributions. Once they go out of support, we stop making changes to rosdep keys for them, but we don't remove them from the REP. Anyway, looks good to me now, thanks for iterating.
There was a problem hiding this comment.
Got it. Thanks for the explanation 👍
rosdep/base.yaml
Outdated
| artful: null | ||
| wily: null |
There was a problem hiding this comment.
Same for artful and wily; since they are out-of-support, we don't need to add exceptions for them.
There was a problem hiding this comment.
Same here. Added those because they were in the list of supported platforms for Kinetic (wily) and Melodic (artful). Also removed these.
* Add rosdep rule for range-v3 library * Specify supported Debian/Ubuntu distributions for range-v3 * Remove out-of-support distribution exceptions for range-v3
Rosdep key for range-v3 library, which: is the basis of the range support in C++20.
I believe the ubuntu, debian and gentoo packages are correct. Package listings in the respective repositories can be found in:
I'm not so sure about fedora. I could not find any related result in fedora packages, but there's some result here. I don't know what that means. Any help here would be appreciated.