Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit NodeletLazy for pipeline with less cpu load #153

Merged
merged 2 commits into from
Aug 15, 2017

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented Aug 8, 2017

Why?

Checking number of subscribers in the callback is not enough to reduce cpu load with nodelet pipeline.
If a leaf nodelet subscribes the parent node's topic, the parent node processes in the callback because pub_output.getNumSubscribers() == 1.

@wkentaro wkentaro added the enhancement New features and improvements. label Aug 8, 2017
@wkentaro wkentaro added this to the 1.5.4 milestone Aug 8, 2017
@wkentaro
Copy link
Member Author

wkentaro commented Aug 8, 2017

Please try using sample_voxel_grid.launch and enable/disable the rviz display of voxel grid output, with watching rosnode info /voxel_grid.
The /voxel_grid node only subscribes the input point cloud topic when it is being subscribed (by rviz).

Copy link
Member

@paulbovbel paulbovbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! LGTM assuming tests pass

@furushchev
Copy link

I'm by change doing the same work and there seems to be a bit difference each other. ( #154 )
Please compare and let us make it better. 👍
@wkentaro @paulbovbel

@wkentaro
Copy link
Member Author

The nodelet not found error is caused by mistaken syntax error of package.xml.
It is reported at ros/rospack#77 and now it is resolved.

@wkentaro wkentaro merged commit 7e7c707 into lunar-devel Aug 15, 2017
@wkentaro wkentaro deleted the nodelet_lazy branch August 15, 2017 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features and improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants