Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.8 to indigo: Release the latest version on indigo? #170

Closed
furushchev opened this issue Jan 13, 2018 · 9 comments
Closed

Release 1.2.8 to indigo: Release the latest version on indigo? #170

furushchev opened this issue Jan 13, 2018 · 9 comments
Assignees
Labels
Task Release, migration, etc.
Milestone

Comments

@furushchev
Copy link

Since the latest version of pcl_ros package is now 1.5.3 and many fixes and improvements are included, it's time to port this into indigo and other distro.
(Note that the version of this package on indigo is still 1.2.7 )

@wkentaro
Copy link
Member

If you would like the use the latest commits in lunar-devel, first you need to cherry-pick commits from lunar-devel to indigo-devel.
https://github.com/ros-perception/perception_pcl/commits/indigo-devel

@wkentaro
Copy link
Member

wkentaro commented Mar 31, 2018

FYI, 1.2 of 1.2.7 means it is for indigo
1.2: indigo
1.3: jade
1.4: kinetic
1.5: lunar
so 1.5.3 is only for lunar.

@furushchev
Copy link
Author

@wkentaro Thanks for clear explanation.
I see. Is there still any chance to port only bugfixes?

Nodelet declaration in pcl_ros is currently malformed and many nodes does not work on indigo.
https://github.com/ros-perception/perception_pcl/blob/1.2.7/pcl_ros/pcl_nodelets.xml

@wkentaro
Copy link
Member

wkentaro commented Mar 31, 2018

I think any changes that have the backcompatibility can be backported.

@furushchev
Copy link
Author

It will be nice if these are ported into older distros:
#134
#165
#153
#160
#147

(I may overlook other necessary pull requests)

@wkentaro wkentaro added the Task Release, migration, etc. label Mar 31, 2018
@wkentaro wkentaro changed the title Release the latest version on indigo? Release the latest version on indigo?: Release 1.2.8 to indigo Mar 31, 2018
@wkentaro wkentaro added this to the 1.2.8 milestone Mar 31, 2018
@wkentaro wkentaro changed the title Release the latest version on indigo?: Release 1.2.8 to indigo Release 1.2.8 to indigo: Release the latest version on indigo? Mar 31, 2018
@wkentaro
Copy link
Member

Sorry, I found backporting all of them is a bit difficult (because they are not backported even for jade).
So I ended up backporting the few commits here: #180
Could you check it?

@wkentaro
Copy link
Member

wkentaro commented Mar 31, 2018

Kinetic will have almost all changes that are included in lunar: #178

@furushchev
Copy link
Author

I leave a comment here since I don't have the right to review your pull request.
Basically looks good to me, it would be better if we got test codes backported so to check if future changes on these distros break the functionality.
Anyway, thank you very much!

@wkentaro
Copy link
Member

wkentaro commented Apr 3, 2018

Released ros/rosdistro#17337

@wkentaro wkentaro closed this as completed Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Release, migration, etc.
Projects
None yet
Development

No branches or pull requests

2 participants