Fix #387: recursive error logging for non-http events #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currently used version of `setuptools` has a bug, so the version requirements are not properly respected. In the current version, `requests>= 0.12.1` always installs the latest version of the package.
Return None object instead
bxsx
requested review from
waltjones,
diegov,
akornich,
bishopb and
pawelsz-rb
This was referenced Sep 19, 2021
Merged
|
This pull request has been linked to Shortcut Story #91322: GH387 GH390: Circular error logging for non-http events in Starlette apps. |
diegov
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR addresses an issue reported in #387.
In the current release, the SDK logs an error if a request object does not exist in the local context. This behavior leads to recursive error logging when
RollbarHandleris used. TheRollbarHandlertries to add the request object to the payload itself, so in the absence of a request in the local context, it again tries to log the error by usingRollbarHandlerand invokesrollbar.get_request()that again causes the same error.The provided solution removes logging errors in case of missing a request in the local context. Instead, it returns
None.Additionally, the PR restricts the storage of request objects only for the ASGI-HTTP scope, so for other scopes, it blindly stores
Nonewithout trying to create the request object itself.I merged the PR #389 branch to pass CI tests. This PR should be merged after approval of #389.
Type of change
Related issues
Checklists
Development
Code review