Fix CI builds by limiting requests version
#389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currently used version of `setuptools` has a bug, so the version requirements are not properly respected. In the current version, `requests>= 0.12.1` always installs the latest version of the package.
bxsx
requested review from
akornich,
bishopb,
diegov,
pawelsz-rb and
waltjones
This was referenced Sep 19, 2021
|
This pull request has been linked to Shortcut Story #91321: CI builds fail due to wrong |
diegov
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The latest version of 'requests` (v2.26.0) breaks our Python 3.4 builds. This is because it fails the compatibility check:
https://github.com/psf/requests/blob/a1a6a549a0143d9b32717dbe3d75cd543ae5a4f6/requests/__init__.py#L98-L104
This makes sense when you look here:
https://github.com/psf/requests/blob/a1a6a549a0143d9b32717dbe3d75cd543ae5a4f6/setup.py#L81
Our CI builds seem to always install the latest version regardless of requirements. This is due to a bug in
setuptools, which does not respect the maximum version required for installing packages.The error doesn't occur for Python 3.3 builds as they have a custom setup where
pipis responsible for installingrequestsand it handles the requirements properly.Python 3.5 passes the compatibility check however, this version is also unsupported and could potentially fail in the future.
This PR explicitly limits the maximum required
requestsversion for each Python version.Type of change
Related issues
Fix [ch91321]
Checklists
Development
Code review