Skip to content

Commit

Permalink
[chore] Allow other matrix jobs to continue when 1 fails (open-teleme…
Browse files Browse the repository at this point in the history
…try#32333)

Updates the individual matrix jobs to keep running even if another has a
failure. This will reduce the number of rerun jobs when there is a
failure and show all the possible matrix failures instead of quitting at
the first.

Example:
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8653658675?pr=32333

---------

Co-authored-by: Alex Boten <[email protected]>
  • Loading branch information
2 people authored and rimitchell committed May 8, 2024
1 parent 4e72113 commit 4f01122
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ jobs:
run: ./.github/workflows/scripts/check-codeowners.sh check_entries_in_allowlist
lint-matrix:
strategy:
fail-fast: false
matrix:
test:
- windows
Expand Down Expand Up @@ -242,6 +243,7 @@ jobs:
git diff --exit-code '.github/ISSUE_TEMPLATE' || (echo 'Dropdowns in issue templates are out of date, please run "make generate-gh-issue-templates" and commit the changes in this PR.' && exit 1)
unittest-matrix:
strategy:
fail-fast: false
matrix:
go-version: ["1.22.2", "1.21.9"] # 1.20 is interpreted as 1.2 without quotes
runner: [ubuntu-latest, actuated-arm64-4cpu-4gb]
Expand Down Expand Up @@ -337,6 +339,7 @@ jobs:

integration-tests-matrix:
strategy:
fail-fast: false
matrix:
group:
- receiver-0
Expand Down Expand Up @@ -454,6 +457,7 @@ jobs:
runs-on: ubuntu-latest
needs: [setup-environment]
strategy:
fail-fast: false
matrix:
os:
- darwin
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ jobs:
env:
KUBECONFIG: /tmp/kube-config-otelcol-e2e-testing
strategy:
fail-fast: false
matrix:
k8s-version:
- "v1.26.0"
Expand Down

0 comments on commit 4f01122

Please sign in to comment.