Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Allow other matrix jobs to continue when 1 fails #32333

Merged

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Apr 11, 2024

Updates the individual matrix jobs to keep running even if another has a failure. This will reduce the number of rerun jobs when there is a failure and show all the possible matrix failures instead of quitting at the first.

Example: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8653658675?pr=32333

@TylerHelmuth TylerHelmuth removed the processor/transform Transform processor label Apr 11, 2024
@TylerHelmuth TylerHelmuth marked this pull request as ready for review April 11, 2024 21:54
@TylerHelmuth TylerHelmuth requested a review from a team as a code owner April 11, 2024 21:54
@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Apr 12, 2024
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea to me.

@TylerHelmuth TylerHelmuth merged commit b9ad949 into open-telemetry:main Apr 15, 2024
170 checks passed
@TylerHelmuth TylerHelmuth deleted the matrix-continue-on-fail branch April 15, 2024 22:41
@github-actions github-actions bot added this to the next release milestone Apr 15, 2024
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this pull request May 8, 2024
…try#32333)

Updates the individual matrix jobs to keep running even if another has a
failure. This will reduce the number of rerun jobs when there is a
failure and show all the possible matrix failures instead of quitting at
the first.

Example:
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8653658675?pr=32333

---------

Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants