Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for embedding plantuml diagram as an object tag #7178

Closed
wants to merge 1 commit into from

Conversation

oneacik
Copy link

@oneacik oneacik commented May 17, 2024

Follow up of: #2754 and #3597

Summary:
Added option to allow plantuml diagrams in svg format to be rendered as tags.

This PR does the following:

  • Adds renderSvgAsObject option
  • Adds branches in editor and server renderer

Tests:
✅ Links in plantuml work in rendered page when option is enabled, also with enabled Security Plugin.
❌ Links in plantuml don't work in editing mode - seem to be sanitised?. Also configuration options are not available in editor renderer.

Tested Using simple markdown:

# Header

```plantuml
:[[http:https://example.com TEST]];

```

@auto-assign auto-assign bot requested a review from NGPixel May 17, 2024 20:23
@oneacik
Copy link
Author

oneacik commented May 17, 2024

Closing for now as deploying on production leads to differen outcomes...

@oneacik oneacik closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants