Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of the original pull request here
Creating this pull request on dev branch as discussed with @NGPixel . I had originally created this a while ago by forking the master branch and hence needed to rewrite this using DOMPurify.
Summary:
Plantuml is currently created as an image which means that links do not work and the plantuml content is treated as a picture and is not searchable
This PR does the following:
object
tag so that it is interactive and selectable (e.g. you can now copy paste text from within the diagram) with a backup non-interactive img tag if browser will not renderobject
As
object
tag is typically insecure, it is checked and sanitised to make sure thatdata
; Any other value results in the node being discardedstyle
/class
/type
/data
/alt
); mismatch in number of attributes being passed in will result in the node being discarded.data
are overriden to the required values for plantuml to work with wikijs explicitly to avoid any code injection scenariosTested using sample markdown