Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always treat the call_script callback as a string of JS code #3521

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Always treat the call_script callback as a string of JS code #3521

merged 3 commits into from
Jun 21, 2024

Commits on Jun 19, 2024

  1. Add test for call_script as an event trigger

    @masenf
    masenf committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    848355a View commit details
    Browse the repository at this point in the history

  2. Always treat the call_script callback as a string of JS code 

    The handler for _call_script always calls `eval` on the `callback` string
anyway, and this allows the callback to be specified for backend-originated
call_script as well as frontend (triggered) call_script.

Fix #3520
    @masenf
    masenf committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    f059bdf View commit details
    Browse the repository at this point in the history

  3. Clean up test_call_script 

    * remove chakra inputs
* remove old-style token checking
    @masenf
    masenf committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    645b4a4 View commit details
    Browse the repository at this point in the history