Always treat the call_script callback as a string of JS code #3521
+36
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handler for _call_script always calls `eval` on the `callback` string anyway, and this allows the callback to be specified for backend-originated call_script as well as frontend (triggered) call_script. Fix #3520
* remove chakra inputs * remove old-style token checking
picklelo
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handler for _call_script always calls
evalon thecallbackstring anyway, and this allows the callback to be specified for backend-originated call_script as well as frontend (triggered) call_script.Fix #3520
Update test cases to catch this issue.
General clean up of test_call_script