Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: TypeScript Type Portability Issues #4467

Open
wants to merge 85 commits into
base: master
Choose a base branch
from
+7,292 −1,554
Open

Fix: TypeScript Type Portability Issues #4467

Changes from 1 commit
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
97e0b9f
Remove `esbuild` from root `package.json`'s `resolutions` field
aryaemami59 Jun 18, 2024
313bcd5
Add `esbuild` to `devDependencies` of `toolkit`
aryaemami59 Jun 18, 2024
e462868
Initial attempt at bundling type definitions
aryaemami59 Jun 18, 2024
682ef46
Add names to build artifacts
aryaemami59 Jun 18, 2024
557a22d
Add `satisfies `TsupOptions[]``
aryaemami59 Jun 18, 2024
1aa9d1f
Fix exports in `src/query/utils/index.ts` barrel file
aryaemami59 Jun 18, 2024
62808c0
Fix exports in `src/query/core/buildMiddleware/index.ts` barrel file
aryaemami59 Jun 18, 2024
35795ea
Fix exports in `src/query/core/index.ts` barrel file
aryaemami59 Jun 18, 2024
ef2139b
Remove relative `declare module`s
aryaemami59 Jun 18, 2024
bafcea8
Fix `build` command
aryaemami59 Jun 18, 2024
7e7c806
Bump `tsup` to version 8.1.0
aryaemami59 Jun 18, 2024
e490c7f
Bump `tsx` to version 4.15.6
aryaemami59 Jun 18, 2024
4fd11f0
Add a script to manually fix `unique symbol` exports
aryaemami59 Jun 18, 2024
08f2113
Export `CombinedSliceReducer`
aryaemami59 Jun 18, 2024
debb422
Convert `TS4023` related interfaces in `createSlice.ts` to types
aryaemami59 Jun 18, 2024
bc5744a
Convert `GetSelectorsOptions` to a `type` alias
aryaemami59 Jun 18, 2024
a3c254c
Rename `Id` to `Simplify` to prevent naming collision
aryaemami59 Jun 18, 2024
8c703e7
Convert `QueryHooks` to a `type` alias
aryaemami59 Jun 18, 2024
929c504
Convert `CaseReducerDefinition` to a `type` alias
aryaemami59 Jun 18, 2024
4340c7b
Export `UNINITIALIZED_VALUE`
aryaemami59 Jun 18, 2024
084fc0e
De-duplicate `type` imports
aryaemami59 Jun 18, 2024
a0baec3
Convert `PromiseWithKnownReason` to a `type` alias
aryaemami59 Jun 18, 2024
580a5e8
Convert `MutationHooks` to a `type` alias
aryaemami59 Jun 18, 2024
ea4382e
Export `StartQueryActionCreatorOptions` type
aryaemami59 Jun 18, 2024
df36b6f
Fix issue with renaming type imports
aryaemami59 Jun 18, 2024
2d63d53
De-duplicate `IgnorePaths` type
aryaemami59 Jun 18, 2024
b1004e9
Remove `Omit` from `tsHelpers.ts` to avoid collision with native `Omit`
aryaemami59 Jun 18, 2024
bf38160
Rename `TypedActionCreator` to `TypedActionCreatorWithMatchFunction`
aryaemami59 Jun 18, 2024
7f63c84
De-duplicate `GetState` type
aryaemami59 Jun 18, 2024
bb48347
Remove unused `_Keep` type in `createAsyncThunk.ts`
aryaemami59 Jun 18, 2024
db48a61
Rename `GetDispatch` to `GetDispatchType`
aryaemami59 Jun 19, 2024
fb3ba9c
Do not export `CacheLifecyclePromises`
aryaemami59 Jun 19, 2024
1302fcf
Do not export `QueryLifecyclePromises`
aryaemami59 Jun 19, 2024
02c9b02
Do not export `LifecycleApi`
aryaemami59 Jun 19, 2024
19750ce
Add `.js` extension to `uncheckedindexed` import path
aryaemami59 Jun 19, 2024
0ab7134
Patch `console-testing-library`
aryaemami59 Jun 19, 2024
8513c89
Add `type` imports in `sorted_state_adapter.test.ts`
aryaemami59 Jun 19, 2024
f000e00
Run type tests with `"moduleResolution": "Bundler"` during CI
aryaemami59 Jun 19, 2024
5bd78f8
Add `@examples-type-portability/bundler` to workspaces
aryaemami59 Jun 19, 2024
1b47971
Update CI to test type portability with `moduleResolution Bundler`
aryaemami59 Jun 19, 2024
51e9cd5
Undo renaming of `Id` to `Simplify`
aryaemami59 Jun 19, 2024
c92ac90
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
aryaemami59 Jun 21, 2024
d8dcd01
Bump `tsx` to version 4.15.7
aryaemami59 Jun 21, 2024
ae87236
Update lockfile
aryaemami59 Jun 21, 2024
dc00686
Fix CI
aryaemami59 Jun 21, 2024
d47bd79
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
aryaemami59 Jun 28, 2024
a61bff5
Bump `tsx` to version 4.16.0
aryaemami59 Jun 29, 2024
93cbe55
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
aryaemami59 Jul 9, 2024
f6a49ef
Bump `tsx` to version 4.16.2
aryaemami59 Jul 9, 2024
e5aaa53
Update lockfile
aryaemami59 Jul 9, 2024
9d4b726
Undo export of `neverResolvedError`
aryaemami59 Jul 9, 2024
160328c
Add TypeScript version matrix for `@examples-type-portability/bundler`
aryaemami59 Jul 9, 2024
5b450cd
Export `BaseEndpointDefinition`
aryaemami59 Jul 9, 2024
e8a56ef
Fix job names in CI
aryaemami59 Jul 9, 2024
d3fe0ba
Bump TypeScript to version 5.5 for `@examples-type-portability/bundler`
aryaemami59 Jul 9, 2024
2c23f0d
Fix TS matrix
aryaemami59 Jul 9, 2024
78a9d60
Convert `React` import to wildcard import
aryaemami59 Jul 9, 2024
39e3df8
Run type tests with `"moduleResolution": "Node10"` in CI
aryaemami59 Jul 9, 2024
8ab3377
Run type tests with `moduleResolution Node10` and `type module` in CI
aryaemami59 Jul 9, 2024
beb818c
Add `next` to TS versions in matrix
aryaemami59 Jul 9, 2024
7008dfb
Enable `preserveSymLinks` when running `tsc` with `Node10`
aryaemami59 Jul 9, 2024
2cef306
Convert `EndpointDefinitionWithQueryFn` to a `type` alias
aryaemami59 Jul 9, 2024
f0bcced
Convert `EndpointDefinitionWithQuery` to a `type` alias
aryaemami59 Jul 9, 2024
c018271
Merge `MutationExtraOptions` interface into a single declaration
aryaemami59 Jul 9, 2024
2b60052
Merge `QueryExtraOptions` interface into a single declaration
aryaemami59 Jul 9, 2024
de845ec
Merge `ApiEndpointQuery` interface into a single declaration
aryaemami59 Jul 9, 2024
9cbb08a
Merge `ApiEndpointMutation` interface into a single declaration
aryaemami59 Jul 9, 2024
25588dd
Merge `ApiModules` interface into a single declaration
aryaemami59 Jul 9, 2024
0b8e8e5
Move `@examples-type-portability/bundler` to `type-portability/bundler`
aryaemami59 Jul 9, 2024
ba32b7b
Add `@examples-type-portability/nodenext-cjs`
aryaemami59 Jul 9, 2024
b0bfe79
Run type portability tests on `@examples-type-portability/nodenext-cjs`
aryaemami59 Jul 9, 2024
59b451b
Remove import attributes as they are not compatible with TypeScript v5.2
aryaemami59 Jul 9, 2024
fc001dd
Add `@examples-type-portability/nodenext-esm`
aryaemami59 Jul 9, 2024
d32d35d
Run type portability tests on `@examples-type-portability/nodenext-esm`
aryaemami59 Jul 9, 2024
b2d1a8c
Use matrices for type portability examples in CI
aryaemami59 Jul 9, 2024
70286c2
Rename `examples` to `example`
aryaemami59 Jul 9, 2024
2e503cc
Skip `Node10` ESM test for `@examples-type-portability/nodenext-cjs`
aryaemami59 Jul 9, 2024
5b5c212
Run `Node10` tests with `preserveSymLinks` enabled
aryaemami59 Jul 9, 2024
e02d94f
Disable `verbatimModuleSyntax` for `Node10`
aryaemami59 Jul 9, 2024
fb85f03
Bump dependencies for `@examples-type-portability/nodenext-esm`
aryaemami59 Jul 9, 2024
0642169
Bump dependencies for `@examples-type-portability/bundler`
aryaemami59 Jul 9, 2024
51154ab
Fix description of `@examples-type-portability/bundler`
aryaemami59 Jul 9, 2024
7116382
Fix `tsconfig.json` of `@examples-type-portability/bundler`
aryaemami59 Jul 9, 2024
da50c57
Fix `package.json` of `@examples-type-portability/bundler`
aryaemami59 Jul 9, 2024
06a30ee
Update lockfile
aryaemami59 Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run type tests with moduleResolution Node10 and type module in CI
  • Loading branch information
@aryaemami59
aryaemami59 committed Jul 9, 2024
commit 8ab33778bf7a815b406aa642c84d55804dee5a5a
5 changes: 5 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,11 @@ jobs:
- name: Test type portability with `moduleResolution Node10`
run: yarn workspace @examples-type-portability/bundler run test --module ESNext --moduleResolution Node10

- name: Test type portability with `moduleResolution Node10` and `type module` in `package.json`
run: |
npm --workspace=@examples-type-portability/bundler pkg set type=module
yarn workspace @examples-type-portability/bundler run test --module ESNext --moduleResolution Node10

test-types:
name: Test Types with TypeScript ${{ matrix.ts }}

Expand Down
Loading