-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: TypeScript Type Portability Issues #4467
Fix: TypeScript Type Portability Issues #4467
Commits on Jun 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 97e0b9f - Browse repository at this point
Copy the full SHA 97e0b9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 313bcd5 - Browse repository at this point
Copy the full SHA 313bcd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e462868 - Browse repository at this point
Copy the full SHA e462868View commit details -
Configuration menu - View commit details
-
Copy full SHA for 682ef46 - Browse repository at this point
Copy the full SHA 682ef46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 557a22d - Browse repository at this point
Copy the full SHA 557a22dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1aa9d1f - Browse repository at this point
Copy the full SHA 1aa9d1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62808c0 - Browse repository at this point
Copy the full SHA 62808c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35795ea - Browse repository at this point
Copy the full SHA 35795eaView commit details -
Remove relative
declare module
s- We also convert some of the problematic types from an `interface` to a `type` alias.
Configuration menu - View commit details
-
Copy full SHA for ef2139b - Browse repository at this point
Copy the full SHA ef2139bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bafcea8 - Browse repository at this point
Copy the full SHA bafcea8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e7c806 - Browse repository at this point
Copy the full SHA 7e7c806View commit details -
Configuration menu - View commit details
-
Copy full SHA for e490c7f - Browse repository at this point
Copy the full SHA e490c7fView commit details -
Add a script to manually fix
unique symbol
exports- The reason why `coreModuleName` and `reactHooksModuleName` are inaccessible is because in order for them to become public `unique symbols` we need to have `export declare const coreModuleName: unique symbol` as opposed to what `rollup-plugin-dts` does which is `declare const coreModuleName: unique symbol; export { coreModuleName }`.
Configuration menu - View commit details
-
Copy full SHA for 4fd11f0 - Browse repository at this point
Copy the full SHA 4fd11f0View commit details
Commits on Jul 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 022a492 - Browse repository at this point
Copy the full SHA 022a492View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80249af - Browse repository at this point
Copy the full SHA 80249afView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc98f3d - Browse repository at this point
Copy the full SHA dc98f3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea83923 - Browse repository at this point
Copy the full SHA ea83923View commit details -
Configuration menu - View commit details
-
Copy full SHA for 993fc94 - Browse repository at this point
Copy the full SHA 993fc94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ad9767 - Browse repository at this point
Copy the full SHA 6ad9767View commit details -
Configuration menu - View commit details
-
Copy full SHA for 880ead2 - Browse repository at this point
Copy the full SHA 880ead2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47665f3 - Browse repository at this point
Copy the full SHA 47665f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a2b423 - Browse repository at this point
Copy the full SHA 7a2b423View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cf59f9 - Browse repository at this point
Copy the full SHA 8cf59f9View commit details -
Fix issue with renaming type imports
- It seems like `tsup` can't handle `import type { Dispatch as ReduxDispatch }`, so we'll remove them.
Configuration menu - View commit details
-
Copy full SHA for fab6018 - Browse repository at this point
Copy the full SHA fab6018View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6600116 - Browse repository at this point
Copy the full SHA 6600116View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26878d1 - Browse repository at this point
Copy the full SHA 26878d1View commit details -
Rename
TypedActionCreator
toTypedActionCreatorWithMatchFunction
- This was done to avoid name collision with `TypedActionCreator` in `src/mapBuilders.ts`
Configuration menu - View commit details
-
Copy full SHA for 7c6c4df - Browse repository at this point
Copy the full SHA 7c6c4dfView commit details -
- This was done to prevent name collision with `GetState` type in `src/dynamicMiddleware/types.ts`
Configuration menu - View commit details
-
Copy full SHA for d78f0b8 - Browse repository at this point
Copy the full SHA d78f0b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6a9aad - Browse repository at this point
Copy the full SHA b6a9aadView commit details -
Rename
GetDispatch
toGetDispatchType
- This was done to avoid name collision with `GetDispatch` type in `src/dynamicMiddleware/types.ts`
Configuration menu - View commit details
-
Copy full SHA for 641d685 - Browse repository at this point
Copy the full SHA 641d685View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96d13da - Browse repository at this point
Copy the full SHA 96d13daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 266ae17 - Browse repository at this point
Copy the full SHA 266ae17View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed624ce - Browse repository at this point
Copy the full SHA ed624ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 653803e - Browse repository at this point
Copy the full SHA 653803eView commit details -
- This was done mainly so we can test the types against `"moduleResolution": "Bundler"`. Previously it would fail due to `console-testing-library` not having a `types` field in it's subpath exports.
Configuration menu - View commit details
-
Copy full SHA for 501d8ea - Browse repository at this point
Copy the full SHA 501d8eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96ad710 - Browse repository at this point
Copy the full SHA 96ad710View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44fd8a1 - Browse repository at this point
Copy the full SHA 44fd8a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49de6d4 - Browse repository at this point
Copy the full SHA 49de6d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c33f568 - Browse repository at this point
Copy the full SHA c33f568View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cfc98c - Browse repository at this point
Copy the full SHA 6cfc98cView commit details -
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
…o fix-type-portability-issues
Configuration menu - View commit details
-
Copy full SHA for bc9bb75 - Browse repository at this point
Copy the full SHA bc9bb75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a729cb - Browse repository at this point
Copy the full SHA 3a729cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ef545d - Browse repository at this point
Copy the full SHA 8ef545dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dff9c0 - Browse repository at this point
Copy the full SHA 7dff9c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c261ea9 - Browse repository at this point
Copy the full SHA c261ea9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a1a0ac - Browse repository at this point
Copy the full SHA 8a1a0acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bf5247 - Browse repository at this point
Copy the full SHA 6bf5247View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c564ea - Browse repository at this point
Copy the full SHA 1c564eaView commit details -
- We need to export the `BaseEndpointDefinition` type because in TypeScript v5.5.3 it causes `TS4023` when exporting `onCacheEntryAdded` or `onQueryStarted`.
Configuration menu - View commit details
-
Copy full SHA for aa65109 - Browse repository at this point
Copy the full SHA aa65109View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1bb825 - Browse repository at this point
Copy the full SHA a1bb825View commit details -
Configuration menu - View commit details
-
Copy full SHA for 496ab20 - Browse repository at this point
Copy the full SHA 496ab20View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4bb3f2 - Browse repository at this point
Copy the full SHA c4bb3f2View commit details -
Convert
React
import to wildcard import- We do this to make sure the type checking does not error when `esModuleInterop` is disabled.
Configuration menu - View commit details
-
Copy full SHA for 1557c05 - Browse repository at this point
Copy the full SHA 1557c05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e1973e - Browse repository at this point
Copy the full SHA 6e1973eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b11bea - Browse repository at this point
Copy the full SHA 0b11beaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8204909 - Browse repository at this point
Copy the full SHA 8204909View commit details -
Enable
preserveSymLinks
when runningtsc
withNode10
- This is done because we are using a local workspace as a dependency and will run into issues if `preserveSymLinks` is not enabled with `moduleResolution Node10`.
Configuration menu - View commit details
-
Copy full SHA for 5d0460b - Browse repository at this point
Copy the full SHA 5d0460bView commit details -
Convert
EndpointDefinitionWithQueryFn
to atype
alias- This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
Configuration menu - View commit details
-
Copy full SHA for da9666d - Browse repository at this point
Copy the full SHA da9666dView commit details -
Convert
EndpointDefinitionWithQuery
to atype
alias- This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
Configuration menu - View commit details
-
Copy full SHA for 044adf2 - Browse repository at this point
Copy the full SHA 044adf2View commit details -
Merge
MutationExtraOptions
interface into a single declaration- This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
Configuration menu - View commit details
-
Copy full SHA for 3c6f307 - Browse repository at this point
Copy the full SHA 3c6f307View commit details -
Merge
QueryExtraOptions
interface into a single declaration- This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
Configuration menu - View commit details
-
Copy full SHA for d2a6eb1 - Browse repository at this point
Copy the full SHA d2a6eb1View commit details -
Merge
ApiEndpointQuery
interface into a single declaration- This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
Configuration menu - View commit details
-
Copy full SHA for 3bb9f98 - Browse repository at this point
Copy the full SHA 3bb9f98View commit details -
Merge
ApiEndpointMutation
interface into a single declaration- This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
Configuration menu - View commit details
-
Copy full SHA for b0a2d30 - Browse repository at this point
Copy the full SHA b0a2d30View commit details -
Merge
ApiModules
interface into a single declaration- This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
Configuration menu - View commit details
-
Copy full SHA for 2909490 - Browse repository at this point
Copy the full SHA 2909490View commit details -
Move
@examples-type-portability/bundler
totype-portability/bundler
- Move `@examples-type-portability/bundler` from `examples/type-portability` to `examples/type-portability/bundler`. This was done to make room for a `NodeNext` test.
Configuration menu - View commit details
-
Copy full SHA for c48067d - Browse repository at this point
Copy the full SHA c48067dView commit details -
Add
@examples-type-portability/nodenext-cjs
- Added `@examples-type-portability/nodenext-cjs` to test type portability with `moduleResolution NodeNext` and TypeScript CJS syntax.
Configuration menu - View commit details
-
Copy full SHA for 8dd5eeb - Browse repository at this point
Copy the full SHA 8dd5eebView commit details -
Configuration menu - View commit details
-
Copy full SHA for f725a82 - Browse repository at this point
Copy the full SHA f725a82View commit details -
Configuration menu - View commit details
-
Copy full SHA for f39ccca - Browse repository at this point
Copy the full SHA f39cccaView commit details -
Add
@examples-type-portability/nodenext-esm
- Added `@examples-type-portability/nodenext-esm` to test type portability with `moduleResolution NodeNext` and ESM syntax.
Configuration menu - View commit details
-
Copy full SHA for 2a65719 - Browse repository at this point
Copy the full SHA 2a65719View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9127d43 - Browse repository at this point
Copy the full SHA 9127d43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b39d78 - Browse repository at this point
Copy the full SHA 0b39d78View commit details -
Configuration menu - View commit details
-
Copy full SHA for db32e8b - Browse repository at this point
Copy the full SHA db32e8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d814f51 - Browse repository at this point
Copy the full SHA d814f51View commit details -
Configuration menu - View commit details
-
Copy full SHA for df474bb - Browse repository at this point
Copy the full SHA df474bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38346a8 - Browse repository at this point
Copy the full SHA 38346a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e79241a - Browse repository at this point
Copy the full SHA e79241aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74da1db - Browse repository at this point
Copy the full SHA 74da1dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c51bb81 - Browse repository at this point
Copy the full SHA c51bb81View commit details -
Configuration menu - View commit details
-
Copy full SHA for d952023 - Browse repository at this point
Copy the full SHA d952023View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96907d5 - Browse repository at this point
Copy the full SHA 96907d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for eebbc81 - Browse repository at this point
Copy the full SHA eebbc81View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbbce41 - Browse repository at this point
Copy the full SHA bbbce41View commit details -
Fix the patch for
console-testing-library
- This was done mainly so we can test the types against `"moduleResolution": "NodeNext"`.
Configuration menu - View commit details
-
Copy full SHA for c4c7f8b - Browse repository at this point
Copy the full SHA c4c7f8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a40e40 - Browse repository at this point
Copy the full SHA 7a40e40View commit details -
Configuration menu - View commit details
-
Copy full SHA for a379ea4 - Browse repository at this point
Copy the full SHA a379ea4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19225e6 - Browse repository at this point
Copy the full SHA 19225e6View commit details -
Convert
ReactDynamicMiddlewareInstance
to atype
alias- Convert `ReactDynamicMiddlewareInstance` to a `type` alias to prevent `TS4023`
Configuration menu - View commit details
-
Copy full SHA for b84bf86 - Browse repository at this point
Copy the full SHA b84bf86View commit details -
Configuration menu - View commit details
-
Copy full SHA for f989c2b - Browse repository at this point
Copy the full SHA f989c2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 137f5d4 - Browse repository at this point
Copy the full SHA 137f5d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54ae0eb - Browse repository at this point
Copy the full SHA 54ae0ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 838710d - Browse repository at this point
Copy the full SHA 838710dView commit details -
Convert
TypedActionCreatorWithMatchFunction
to atype
alias- Convert `TypedActionCreatorWithMatchFunction` to a `type` alias to prevent `TS4023`
Configuration menu - View commit details
-
Copy full SHA for c50bbb6 - Browse repository at this point
Copy the full SHA c50bbb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 019be7a - Browse repository at this point
Copy the full SHA 019be7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28af348 - Browse repository at this point
Copy the full SHA 28af348View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a2af21 - Browse repository at this point
Copy the full SHA 8a2af21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eb130a - Browse repository at this point
Copy the full SHA 7eb130aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d45110 - Browse repository at this point
Copy the full SHA 9d45110View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfaddd3 - Browse repository at this point
Copy the full SHA dfaddd3View commit details -
Add tests for custom module creation via declaration merging
- Introduced tests to ensure custom modules can still be created despite the removal of some module augmentations. - These tests aim to reinforce confidence in the ability to create custom modules, which was the original purpose of the augmentations.
Configuration menu - View commit details
-
Copy full SHA for 2da072e - Browse repository at this point
Copy the full SHA 2da072eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 453d833 - Browse repository at this point
Copy the full SHA 453d833View commit details -
Configuration menu - View commit details
-
Copy full SHA for 883300f - Browse repository at this point
Copy the full SHA 883300fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83971b8 - Browse repository at this point
Copy the full SHA 83971b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8c342f - Browse repository at this point
Copy the full SHA f8c342fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b5a914 - Browse repository at this point
Copy the full SHA 5b5a914View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2db682a - Browse repository at this point
Copy the full SHA 2db682aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7513d3b - Browse repository at this point
Copy the full SHA 7513d3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4ac1e1 - Browse repository at this point
Copy the full SHA d4ac1e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3e079b - Browse repository at this point
Copy the full SHA b3e079bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f8ad61 - Browse repository at this point
Copy the full SHA 6f8ad61View commit details -
Add
BuildThunksApiEndpointQuery
type- This was done to help split the `ApiEndpointQuery` type into multiple types instead of merging multiple `interface` declarations.
Configuration menu - View commit details
-
Copy full SHA for 5e5d4bf - Browse repository at this point
Copy the full SHA 5e5d4bfView commit details -
Add
BuildInitiateApiEndpointQuery
type- This was done to help split the `ApiEndpointQuery` type into multiple types instead of merging multiple `interface` declarations.
Configuration menu - View commit details
-
Copy full SHA for a303ae0 - Browse repository at this point
Copy the full SHA a303ae0View commit details -
Add
BuildSelectorsApiEndpointQuery
type- This was done to help split the `ApiEndpointQuery` type into multiple types instead of merging multiple `interface` declarations.
Configuration menu - View commit details
-
Copy full SHA for 6b680e1 - Browse repository at this point
Copy the full SHA 6b680e1View commit details -
Add
BuildThunksApiEndpointMutation
type- This was done to help split the `ApiEndpointMutation` type into multiple types instead of merging multiple `interface` declarations.
Configuration menu - View commit details
-
Copy full SHA for 30a868e - Browse repository at this point
Copy the full SHA 30a868eView commit details -
Add
BuildInitiateApiEndpointMutation
type- This was done to help split the `ApiEndpointMutation` type into multiple types instead of merging multiple `interface` declarations.
Configuration menu - View commit details
-
Copy full SHA for 5c16d34 - Browse repository at this point
Copy the full SHA 5c16d34View commit details -
Add
BuildSelectorsApiEndpointMutation
type- This was done to help split the `ApiEndpointMutation` type into multiple types instead of merging multiple `interface` declarations.
Configuration menu - View commit details
-
Copy full SHA for 10bb727 - Browse repository at this point
Copy the full SHA 10bb727View commit details -
Configuration menu - View commit details
-
Copy full SHA for bae9b3c - Browse repository at this point
Copy the full SHA bae9b3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 593013c - Browse repository at this point
Copy the full SHA 593013cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6064600 - Browse repository at this point
Copy the full SHA 6064600View commit details -
Configuration menu - View commit details
-
Copy full SHA for fac9818 - Browse repository at this point
Copy the full SHA fac9818View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc9b3b8 - Browse repository at this point
Copy the full SHA fc9b3b8View commit details -
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
…o fix-type-portability-issues
Configuration menu - View commit details
-
Copy full SHA for c8233fc - Browse repository at this point
Copy the full SHA c8233fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec0d450 - Browse repository at this point
Copy the full SHA ec0d450View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6859df5 - Browse repository at this point
Copy the full SHA 6859df5View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa34c66 - Browse repository at this point
Copy the full SHA aa34c66View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9e74ab - Browse repository at this point
Copy the full SHA c9e74abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39589d9 - Browse repository at this point
Copy the full SHA 39589d9View commit details
Commits on Jul 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bd83e94 - Browse repository at this point
Copy the full SHA bd83e94View commit details