Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: TypeScript Type Portability Issues #4467

Merged
merged 127 commits into from
Jul 25, 2024

Commits on Jun 18, 2024

  1. Configuration menu
    Copy the full SHA
    97e0b9f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    313bcd5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e462868 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    682ef46 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    557a22d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1aa9d1f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    62808c0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    35795ea View commit details
    Browse the repository at this point in the history
  9. Remove relative declare modules

    - We also convert some of the problematic types from an `interface` to a `type` alias.
    aryaemami59 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    ef2139b View commit details
    Browse the repository at this point in the history
  10. Fix build command

    aryaemami59 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    bafcea8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    7e7c806 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e490c7f View commit details
    Browse the repository at this point in the history
  13. Add a script to manually fix unique symbol exports

    - The reason why `coreModuleName` and `reactHooksModuleName` are inaccessible is because in order for them to become public `unique symbols` we need to have `export declare const coreModuleName: unique symbol` as opposed to what `rollup-plugin-dts` does which is `declare const coreModuleName: unique symbol; export {
      coreModuleName }`.
    aryaemami59 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4fd11f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Configuration menu
    Copy the full SHA
    022a492 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    80249af View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc98f3d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ea83923 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    993fc94 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6ad9767 View commit details
    Browse the repository at this point in the history
  7. De-duplicate type imports

    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    880ead2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    47665f3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7a2b423 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    8cf59f9 View commit details
    Browse the repository at this point in the history
  11. Fix issue with renaming type imports

    - It seems like `tsup` can't handle `import type { Dispatch as ReduxDispatch }`, so we'll remove them.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    fab6018 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6600116 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    26878d1 View commit details
    Browse the repository at this point in the history
  14. Rename TypedActionCreator to TypedActionCreatorWithMatchFunction

    - This was done to avoid name collision with `TypedActionCreator` in `src/mapBuilders.ts`
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    7c6c4df View commit details
    Browse the repository at this point in the history
  15. De-duplicate GetState type

    - This was done to prevent name collision with `GetState` type in `src/dynamicMiddleware/types.ts`
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d78f0b8 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    b6a9aad View commit details
    Browse the repository at this point in the history
  17. Rename GetDispatch to GetDispatchType

    - This was done to avoid name collision with `GetDispatch` type in `src/dynamicMiddleware/types.ts`
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    641d685 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    96d13da View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    266ae17 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    ed624ce View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    653803e View commit details
    Browse the repository at this point in the history
  22. Patch console-testing-library

    - This was done mainly so we can test the types against `"moduleResolution": "Bundler"`. Previously it would fail due to `console-testing-library` not having a `types` field in it's subpath exports.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    501d8ea View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    96ad710 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    44fd8a1 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    49de6d4 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    c33f568 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    6cfc98c View commit details
    Browse the repository at this point in the history
  28. Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…

    …o fix-type-portability-issues
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    bc9bb75 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    3a729cb View commit details
    Browse the repository at this point in the history
  30. Update lockfile

    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8ef545d View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    7dff9c0 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    c261ea9 View commit details
    Browse the repository at this point in the history
  33. Update lockfile

    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8a1a0ac View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    6bf5247 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    1c564ea View commit details
    Browse the repository at this point in the history
  36. Export BaseEndpointDefinition

    - We need to export the `BaseEndpointDefinition` type because in TypeScript v5.5.3 it causes `TS4023` when exporting `onCacheEntryAdded` or `onQueryStarted`.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    aa65109 View commit details
    Browse the repository at this point in the history
  37. Fix job names in CI

    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a1bb825 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    496ab20 View commit details
    Browse the repository at this point in the history
  39. Fix TS matrix

    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c4bb3f2 View commit details
    Browse the repository at this point in the history
  40. Convert React import to wildcard import

    - We do this to make sure the type checking does not error when `esModuleInterop` is disabled.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1557c05 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    6e1973e View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    0b11bea View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    8204909 View commit details
    Browse the repository at this point in the history
  44. Enable preserveSymLinks when running tsc with Node10

    - This is done because we are using a local workspace as a dependency and will run into issues if `preserveSymLinks` is not enabled with `moduleResolution Node10`.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5d0460b View commit details
    Browse the repository at this point in the history
  45. Convert EndpointDefinitionWithQueryFn to a type alias

    - This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    da9666d View commit details
    Browse the repository at this point in the history
  46. Convert EndpointDefinitionWithQuery to a type alias

    - This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    044adf2 View commit details
    Browse the repository at this point in the history
  47. Merge MutationExtraOptions interface into a single declaration

    - This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3c6f307 View commit details
    Browse the repository at this point in the history
  48. Merge QueryExtraOptions interface into a single declaration

    - This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d2a6eb1 View commit details
    Browse the repository at this point in the history
  49. Merge ApiEndpointQuery interface into a single declaration

    - This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3bb9f98 View commit details
    Browse the repository at this point in the history
  50. Merge ApiEndpointMutation interface into a single declaration

    - This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b0a2d30 View commit details
    Browse the repository at this point in the history
  51. Merge ApiModules interface into a single declaration

    - This was done to resolve potential `TS4023` errors with TypeScript version 5.5.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2909490 View commit details
    Browse the repository at this point in the history
  52. Move @examples-type-portability/bundler to type-portability/bundler

    - Move `@examples-type-portability/bundler` from `examples/type-portability` to `examples/type-portability/bundler`. This was done to make room for a `NodeNext` test.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c48067d View commit details
    Browse the repository at this point in the history
  53. Add @examples-type-portability/nodenext-cjs

    - Added `@examples-type-portability/nodenext-cjs` to test type portability with `moduleResolution NodeNext` and TypeScript CJS syntax.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8dd5eeb View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    f725a82 View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    f39ccca View commit details
    Browse the repository at this point in the history
  56. Add @examples-type-portability/nodenext-esm

    - Added `@examples-type-portability/nodenext-esm` to test type portability with `moduleResolution NodeNext` and ESM syntax.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2a65719 View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    9127d43 View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    0b39d78 View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    db32e8b View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    d814f51 View commit details
    Browse the repository at this point in the history
  61. Configuration menu
    Copy the full SHA
    df474bb View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    38346a8 View commit details
    Browse the repository at this point in the history
  63. Configuration menu
    Copy the full SHA
    e79241a View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    74da1db View commit details
    Browse the repository at this point in the history
  65. Configuration menu
    Copy the full SHA
    c51bb81 View commit details
    Browse the repository at this point in the history
  66. Configuration menu
    Copy the full SHA
    d952023 View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    96907d5 View commit details
    Browse the repository at this point in the history
  68. Update lockfile

    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    eebbc81 View commit details
    Browse the repository at this point in the history
  69. Export _NEVER symbol

    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    bbbce41 View commit details
    Browse the repository at this point in the history
  70. Fix the patch for console-testing-library

    - This was done mainly so we can test the types against `"moduleResolution": "NodeNext"`.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c4c7f8b View commit details
    Browse the repository at this point in the history
  71. Bump tsup and esbuild

    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    7a40e40 View commit details
    Browse the repository at this point in the history
  72. Configuration menu
    Copy the full SHA
    a379ea4 View commit details
    Browse the repository at this point in the history
  73. Configuration menu
    Copy the full SHA
    19225e6 View commit details
    Browse the repository at this point in the history
  74. Convert ReactDynamicMiddlewareInstance to a type alias

    - Convert `ReactDynamicMiddlewareInstance` to a `type` alias to prevent `TS4023`
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b84bf86 View commit details
    Browse the repository at this point in the history
  75. Configuration menu
    Copy the full SHA
    f989c2b View commit details
    Browse the repository at this point in the history
  76. Configuration menu
    Copy the full SHA
    137f5d4 View commit details
    Browse the repository at this point in the history
  77. Configuration menu
    Copy the full SHA
    54ae0eb View commit details
    Browse the repository at this point in the history
  78. Configuration menu
    Copy the full SHA
    838710d View commit details
    Browse the repository at this point in the history
  79. Convert TypedActionCreatorWithMatchFunction to a type alias

    - Convert `TypedActionCreatorWithMatchFunction` to a `type` alias to prevent `TS4023`
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c50bbb6 View commit details
    Browse the repository at this point in the history
  80. Configuration menu
    Copy the full SHA
    019be7a View commit details
    Browse the repository at this point in the history
  81. Configuration menu
    Copy the full SHA
    28af348 View commit details
    Browse the repository at this point in the history
  82. Configuration menu
    Copy the full SHA
    8a2af21 View commit details
    Browse the repository at this point in the history
  83. Configuration menu
    Copy the full SHA
    7eb130a View commit details
    Browse the repository at this point in the history
  84. Configuration menu
    Copy the full SHA
    9d45110 View commit details
    Browse the repository at this point in the history
  85. Configuration menu
    Copy the full SHA
    dfaddd3 View commit details
    Browse the repository at this point in the history
  86. Add tests for custom module creation via declaration merging

    - Introduced tests to ensure custom modules can still be created despite the removal of some module augmentations.
    - These tests aim to reinforce confidence in the ability to create custom modules, which was the original purpose of the augmentations.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2da072e View commit details
    Browse the repository at this point in the history
  87. Configuration menu
    Copy the full SHA
    453d833 View commit details
    Browse the repository at this point in the history
  88. Configuration menu
    Copy the full SHA
    883300f View commit details
    Browse the repository at this point in the history
  89. Configuration menu
    Copy the full SHA
    83971b8 View commit details
    Browse the repository at this point in the history
  90. Configuration menu
    Copy the full SHA
    f8c342f View commit details
    Browse the repository at this point in the history
  91. Configuration menu
    Copy the full SHA
    5b5a914 View commit details
    Browse the repository at this point in the history
  92. Configuration menu
    Copy the full SHA
    2db682a View commit details
    Browse the repository at this point in the history
  93. Configuration menu
    Copy the full SHA
    7513d3b View commit details
    Browse the repository at this point in the history
  94. Configuration menu
    Copy the full SHA
    d4ac1e1 View commit details
    Browse the repository at this point in the history
  95. Configuration menu
    Copy the full SHA
    b3e079b View commit details
    Browse the repository at this point in the history
  96. Configuration menu
    Copy the full SHA
    6f8ad61 View commit details
    Browse the repository at this point in the history
  97. Add BuildThunksApiEndpointQuery type

    - This was done to help split the `ApiEndpointQuery` type into multiple types instead of merging multiple `interface` declarations.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5e5d4bf View commit details
    Browse the repository at this point in the history
  98. Add BuildInitiateApiEndpointQuery type

    - This was done to help split the `ApiEndpointQuery` type into multiple types instead of merging multiple `interface` declarations.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a303ae0 View commit details
    Browse the repository at this point in the history
  99. Add BuildSelectorsApiEndpointQuery type

    - This was done to help split the `ApiEndpointQuery` type into multiple types instead of merging multiple `interface` declarations.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6b680e1 View commit details
    Browse the repository at this point in the history
  100. Add BuildThunksApiEndpointMutation type

    - This was done to help split the `ApiEndpointMutation` type into multiple types instead of merging multiple `interface` declarations.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    30a868e View commit details
    Browse the repository at this point in the history
  101. Add BuildInitiateApiEndpointMutation type

    - This was done to help split the `ApiEndpointMutation` type into multiple types instead of merging multiple `interface` declarations.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5c16d34 View commit details
    Browse the repository at this point in the history
  102. Add BuildSelectorsApiEndpointMutation type

    - This was done to help split the `ApiEndpointMutation` type into multiple types instead of merging multiple `interface` declarations.
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    10bb727 View commit details
    Browse the repository at this point in the history
  103. Configuration menu
    Copy the full SHA
    bae9b3c View commit details
    Browse the repository at this point in the history
  104. Configuration menu
    Copy the full SHA
    593013c View commit details
    Browse the repository at this point in the history
  105. Configuration menu
    Copy the full SHA
    6064600 View commit details
    Browse the repository at this point in the history
  106. Configuration menu
    Copy the full SHA
    fac9818 View commit details
    Browse the repository at this point in the history
  107. Configuration menu
    Copy the full SHA
    fc9b3b8 View commit details
    Browse the repository at this point in the history
  108. Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…

    …o fix-type-portability-issues
    aryaemami59 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c8233fc View commit details
    Browse the repository at this point in the history
  109. Configuration menu
    Copy the full SHA
    ec0d450 View commit details
    Browse the repository at this point in the history
  110. Configuration menu
    Copy the full SHA
    6859df5 View commit details
    Browse the repository at this point in the history
  111. Configuration menu
    Copy the full SHA
    aa34c66 View commit details
    Browse the repository at this point in the history
  112. Configuration menu
    Copy the full SHA
    c9e74ab View commit details
    Browse the repository at this point in the history
  113. Configuration menu
    Copy the full SHA
    39589d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Configuration menu
    Copy the full SHA
    bd83e94 View commit details
    Browse the repository at this point in the history