Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting.md to clarify disabling any other formatting extensions #4091

Merged
merged 4 commits into from
Nov 19, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update linting.md
  • Loading branch information
kraenhansen committed Nov 19, 2021
commit fae9717ada4ba6d192510464ac8456030d30bffe
4 changes: 1 addition & 3 deletions contrib/linting.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,9 @@ To help yourself keep your code passing linters at all times, it's highly recomm
- Disable any other code formatting extensions (such as Prettier / [`esbenp.prettier-vscode`](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode)) for the workspace, as they might interfere with the format enforced by eslint.
- Make sure you've enabled "format on save" on your workspace.

Both the eslint plugin and formatting on save can be enabled via the UI or you can <kbd>Cmd</kbd> + <kbd>P</kbd>, type *"> Preferences Open Workspace Settings (JSON)"* and paste in the following in the `settings` object:
The eslint formatting on save can be enabled via the UI or you can <kbd>Cmd</kbd> + <kbd>P</kbd>, type *"> Preferences Open Workspace Settings (JSON)"* and paste in the following in the `settings` object:

```json
"eslint.format.enable": true,
"eslint.validate": ["typescript", "typescriptreact", "javascript"],
"editor.formatOnSave": true
```

Expand Down